Repository navigation
Configure Harbor registry for Docker builds - #14
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR configures the project to use a private Harbor registry at harbor.dataknife.net for Docker image storage and distribution, transitioning away from local Docker builds. The changes introduce automated CI/CD integration with Harbor and add new Makefile targets for Harbor operations.
Key changes:
- Configures Docker Compose to pull from Harbor registry instead of building locally
- Adds Harbor login, push, and pull commands to Makefile with credential validation
- Updates GitHub Actions workflow to push images to Harbor using self-hosted runners and registry-based caching
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 10 comments.
| File | Description |
|---|---|
| docker-compose.yml | Replaces local build with Harbor registry image reference |
| Makefile | Adds Harbor registry integration targets (login, push, pull) with credential validation |
| .github/workflows/docker.yml | Converts workflow to build and push to Harbor with self-hosted runners and registry caching |
| .github/HARBOR_SETUP.md | Provides setup documentation for Harbor credentials and usage instructions |
- GitLab CI: Use --password-stdin for secure Harbor login - GitLab CI: Build once and tag instead of building twice - GitLab CI: Replace deprecated 'only' with 'rules' - Makefile: Use --password-stdin for docker-login (security) - Makefile: Add .PHONY declarations for new targets - Makefile: Reorder docker-push dependencies for clarity - GitHub Actions: Standardize checkout action to v5 - GitHub Actions: Remove --force flag, use credential helper for git push - GitHub Actions: Fix multiline command formatting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR configures the repository to use Harbor registry for Docker image storage and updates GitHub Actions workflows to use self-hosted runners.
Changes
Harbor Registry
harbor.dataknife.net/library/high-command-apiGitHub Secrets Required
HARBOR_USERNAMEHARBOR_PASSWORDSecrets are already configured in the repository.