Repository navigation
chore(github-runner): remove unwired ARC overlay - #59
Merged
Merged
Conversation
github-runner/overlays/nprd-apps was never in any Fleet GitRepo path and the ARC controller it depended on was uninstalled from all clusters on 2026-10-05 (rancher-deploy#46). Drop the overlay, its docs and secret example, and the GitHub half of runner-setup.sh. Co-authored-by: Cursor <cursoragent@cursor.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
github-runner/overlays/nprd-apps(an ARCAutoscalingRunnerSet) was dead code. It isn't in any Fleet GitRepo path (live paths: gitlab-runner, harbor, grafana, monitoring on nprd; monitoring on poc; monitoring and authentik on prd), andfleet-gitrepo.yamlonly had it commented out. The ARC controller it needed was uninstalled from all clusters on 2026-10-05, after confirming zero runner scale sets anywhere (DataKnifeAI/rancher-deploy#46).Changes
github-runner/,docs/github-runner/,docs/GITHUB_RUNNER.md,secrets/github-runner/.scripts/runner-setup.sh: GitLab only now (allkept as an alias; it no longer createsactions-runner-system).docs/DEPLOYMENT.md,docs/FLEET_STRUCTURE.md,docs/README.md,README.md,fleet-gitrepo.yaml: drop GitHub runner references.No live impact: Fleet never deployed this path.
Note
Low Risk
Documentation and dead-manifest removal only; Fleet was not deploying the removed overlay.
Overview
Removes the unused GitHub Actions Runner (official ARC
AutoscalingRunnerSet) stack from the repo after the controller was uninstalled and Fleet never syncedgithub-runner/overlays/nprd-apps.Deletes
github-runner/(base + nprd-apps overlay),docs/github-runner/,docs/GITHUB_RUNNER.md, andsecrets/github-runner/.fleet-gitrepo.yamldrops the commentedgithub-runnerpath so monitored paths match what actually deploys (GitLab runner, Harbor, Grafana, monitoring).scripts/runner-setup.shis GitLab-only: noactions-runner-systemnamespace or GitHub PAT/App secret flow; default action isgitlab(allstill aliases to GitLab). Deployment and Fleet docs (DEPLOYMENT.md,FLEET_STRUCTURE.md,docs/README.md, rootREADMEstructure tree) are trimmed to Harbor + GitLab runner workflows.No expected cluster impact if Fleet was already excluding this path.
Reviewed by Cursor Bugbot for commit 4210843. Bugbot is set up for automated code reviews on this repo. Configure here.