Typed GraphQL Service Layer #1672
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for thriving-cassata-78ae72 canceled.
|
shangyian
force-pushed
the
api-ui-mocks
branch
from
1d2f8e4 to
b5d8652
Compare
shangyian
force-pushed
the
api-ui-mocks
branch
from
f7a6699 to
e97ebfb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR sets up GraphQL code gen and creates a fully-typed GraphQL service layer for the DJ UI. All existing GraphQL methods in
DJService.jsnow delegate to the new typedDJGraphQLService.ts. This provides type safety without changing any existing components.Test Plan
make checkpassesmake testshows 100% unit test coverageDeployment Plan