Conversation
|
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e3b172f152
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| tests/parametric/test_config_consistency.py::Test_Stable_Config_Default::test_default_config: missing_feature (runtime metrics default changing to true) | ||
| tests/parametric/test_config_consistency.py::Test_Stable_Config_Default::test_invalid_files: missing_feature (runtime metrics default changing to true) | ||
| tests/parametric/test_config_consistency.py::Test_Stable_Config_Default::test_unknown_key_skipped: missing_feature (runtime metrics default changing to true) |
There was a problem hiding this comment.
Narrow stable-config skips to runtime-metrics cases
These manifest entries disable three entire test methods for all supported .NET versions, but the stated reason is only the runtime-metrics default flip. In particular, test_default_config also validates profiling, data-streams, and logs-injection paths (tests/parametric/test_config_consistency.py:424-474), so this change suppresses unrelated coverage and can hide regressions in those configs. Please scope the skip to the specific failing runtime-metrics behavior (or version range) instead of skipping whole methods.
Useful? React with 👍 / 👎.
Motivation
Working on enabling Runtime Metrics by default on .NET so need to disable so tests pass and related PRs can be merged.
Changes
Disables the currently failing tests in the dotnet manifest file.
Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present