Skip to content

Skipping Test_Stable_Config_Default .NET Tests#6485

Open
link04 wants to merge 1 commit intomainfrom
maximo/runtime-metrics-disables-defaults-test
Open

Skipping Test_Stable_Config_Default .NET Tests#6485
link04 wants to merge 1 commit intomainfrom
maximo/runtime-metrics-disables-defaults-test

Conversation

@link04
Copy link
Contributor

@link04 link04 commented Mar 12, 2026

Motivation

Working on enabling Runtime Metrics by default on .NET so need to disable so tests pass and related PRs can be merged.

Changes

Disables the currently failing tests in the dotnet manifest file.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@github-actions
Copy link
Contributor

CODEOWNERS have been resolved as:

manifests/dotnet.yml                                                    @DataDog/apm-dotnet @DataDog/asm-dotnet

@link04 link04 marked this pull request as ready for review March 12, 2026 19:09
@link04 link04 requested review from a team as code owners March 12, 2026 19:09
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e3b172f152

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +772 to +774
tests/parametric/test_config_consistency.py::Test_Stable_Config_Default::test_default_config: missing_feature (runtime metrics default changing to true)
tests/parametric/test_config_consistency.py::Test_Stable_Config_Default::test_invalid_files: missing_feature (runtime metrics default changing to true)
tests/parametric/test_config_consistency.py::Test_Stable_Config_Default::test_unknown_key_skipped: missing_feature (runtime metrics default changing to true)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Narrow stable-config skips to runtime-metrics cases

These manifest entries disable three entire test methods for all supported .NET versions, but the stated reason is only the runtime-metrics default flip. In particular, test_default_config also validates profiling, data-streams, and logs-injection paths (tests/parametric/test_config_consistency.py:424-474), so this change suppresses unrelated coverage and can hide regressions in those configs. Please scope the skip to the specific failing runtime-metrics behavior (or version range) instead of skipping whole methods.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant