Adds system test that reports grpc status code in the stats#6483
Adds system test that reports grpc status code in the stats#6483
Conversation
|
|
b7577af to
5e94312
Compare
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🔗 Commit SHA: a4048d8 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback! |
* Adds a parameteric test for the grpc status code * Replace parametric test by regular for the grpc status code
5e94312 to
a4048d8
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a4048d858b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @missing_feature( | ||
| context.library != "java" or context.library < "java@1.61.0", | ||
| reason="GRPCStatusCode stats payload field was added in java@1.61.0", |
There was a problem hiding this comment.
Move library/version gating from decorators to manifests
This test deactivation logic is encoded in @missing_feature conditions that depend only on library version and weblog variant, but docs/edit/skip-tests.md explicitly requires those conditions to live in manifest files ("Always prefer manifest files" and "If your condition depends only on library name, library version, or weblog variant, use the manifest file instead", lines 3-13). Keeping this in decorators makes activation state harder to track and maintain (especially for automated manifest-based activation/deactivation workflows), which can leave this test silently skipped longer than intended as versions evolve.
Useful? React with 👍 / 👎.
Motivation
The java agent didn't included the gRPC status code in the stats payload. It will do so in 1.61.0. So let's add a system test to verify that.