Skip to content

Adds system test that reports grpc status code in the stats#6483

Open
bric3 wants to merge 1 commit intomainfrom
bdu/report-grpc-status-code-to-tracer-client-computed-stats
Open

Adds system test that reports grpc status code in the stats#6483
bric3 wants to merge 1 commit intomainfrom
bdu/report-grpc-status-code-to-tracer-client-computed-stats

Conversation

@bric3
Copy link
Contributor

@bric3 bric3 commented Mar 12, 2026

Motivation

The java agent didn't included the gRPC status code in the stats payload. It will do so in 1.61.0. So let's add a system test to verify that.

@github-actions
Copy link
Contributor

CODEOWNERS have been resolved as:

tests/stats/test_stats.py                                               @DataDog/system-tests-core
utils/docker_fixtures/spec/trace.py                                     @DataDog/system-tests-core

@bric3 bric3 force-pushed the bdu/report-grpc-status-code-to-tracer-client-computed-stats branch 3 times, most recently from b7577af to 5e94312 Compare March 13, 2026 15:49
@datadog-prod-us1-5
Copy link

datadog-prod-us1-5 bot commented Mar 13, 2026

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: a4048d8 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!

* Adds a parameteric test for the grpc status code
* Replace parametric test by regular for the grpc status code
@bric3 bric3 force-pushed the bdu/report-grpc-status-code-to-tracer-client-computed-stats branch from 5e94312 to a4048d8 Compare March 13, 2026 17:55
@bric3 bric3 marked this pull request as ready for review March 13, 2026 19:00
@bric3 bric3 requested a review from a team as a code owner March 13, 2026 19:00
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a4048d858b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +105 to +107
@missing_feature(
context.library != "java" or context.library < "java@1.61.0",
reason="GRPCStatusCode stats payload field was added in java@1.61.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Move library/version gating from decorators to manifests

This test deactivation logic is encoded in @missing_feature conditions that depend only on library version and weblog variant, but docs/edit/skip-tests.md explicitly requires those conditions to live in manifest files ("Always prefer manifest files" and "If your condition depends only on library name, library version, or weblog variant, use the manifest file instead", lines 3-13). Keeping this in decorators makes activation state harder to track and maintain (especially for automated manifest-based activation/deactivation workflows), which can leave this test silently skipped longer than intended as versions evolve.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants