Use latest version of Nginx, 1.29.6#6473
Merged
cbeauchesne merged 3 commits intomainfrom Mar 13, 2026
Merged
Conversation
Contributor
|
|
|
✨ Fix all issues with BitsAI or with Cursor
|
| # | ||
| # * Agent: Docker hub datadog/agent-dev:master-py3 | ||
| # * cpp_httpd: Github action artifact | ||
| # * cpp_nginx: From circle ci |
Contributor
There was a problem hiding this comment.
I can't seem to write a suggestion since you removed the line, but you should replace From circle ci with Github action artifact
Contributor
Author
There was a problem hiding this comment.
Well, I think this comment is actually useless (*), and one can see that other comments are wrong (*) and that several components are missing in this list.
(*): always prefer clear naming in code rather than a comment that can become out of sync with the code ;-)
zacharycmontoya
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Following the delivery of Nginx Datadog 1.13.0, use, in System Tests, the latest Nginx version.
Changes
utils/scripts/load-binary.sh, remove deprecatedget_circleci_artifact().This PR works with DataDog/nginx-datadog#325.
Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present