Skip to content

Use latest version of Nginx, 1.29.6#6473

Merged
cbeauchesne merged 3 commits intomainfrom
xlamorlette/get-nginx-artifact-from-gitlab
Mar 13, 2026
Merged

Use latest version of Nginx, 1.29.6#6473
cbeauchesne merged 3 commits intomainfrom
xlamorlette/get-nginx-artifact-from-gitlab

Conversation

@xlamorlette-datadog
Copy link
Contributor

@xlamorlette-datadog xlamorlette-datadog commented Mar 11, 2026

Motivation

Following the delivery of Nginx Datadog 1.13.0, use, in System Tests, the latest Nginx version.

Changes

  • Upgrade the used Nginx version from 1.29.5 to 1.29.6.
  • In utils/scripts/load-binary.sh, remove deprecated get_circleci_artifact().

This PR works with DataDog/nginx-datadog#325.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@github-actions
Copy link
Contributor

CODEOWNERS have been resolved as:

utils/build/docker/cpp_nginx/nginx.Dockerfile                           @DataDog/system-tests-core
utils/scripts/load-binary.sh                                            @DataDog/system-tests-core

@datadog-prod-us1-4
Copy link

datadog-prod-us1-4 bot commented Mar 11, 2026

⚠️ Tests

Fix all issues with BitsAI or with Cursor

⚠️ Warnings

🧪 1 Test failed

tests.debugger.test_debugger_inproduct_enablement.Test_Debugger_InProduct_Enablement_Exception_Replay.test_inproduct_enablement_exception_replay[poc] from system_tests_suite (Datadog) (Fix with Cursor)
AssertionError: Expected snapshots to be emitting after enabling exception replay
assert False
 +  where False = <tests.debugger.test_debugger_inproduct_enablement.Test_Debugger_InProduct_Enablement_Exception_Replay object at 0x7f36f37d8c80>.er_explicit_enabled

self = <tests.debugger.test_debugger_inproduct_enablement.Test_Debugger_InProduct_Enablement_Exception_Replay object at 0x7f36f37d8c80>

    def test_inproduct_enablement_exception_replay(self):
        self.assert_rc_state_not_error()
        self.assert_all_weblog_responses_ok(expected_code=500)
    
...

ℹ️ Info

No other issues found (see more)

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: ad8a376 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!

@xlamorlette-datadog xlamorlette-datadog marked this pull request as ready for review March 12, 2026 15:35
@xlamorlette-datadog xlamorlette-datadog requested a review from a team as a code owner March 12, 2026 15:35
@xlamorlette-datadog xlamorlette-datadog changed the title Xlamorlette/get nginx artifact from gitlab Use latest version of Nginx, 1.29.6 Mar 12, 2026
#
# * Agent: Docker hub datadog/agent-dev:master-py3
# * cpp_httpd: Github action artifact
# * cpp_nginx: From circle ci
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't seem to write a suggestion since you removed the line, but you should replace From circle ci with Github action artifact

Copy link
Contributor Author

@xlamorlette-datadog xlamorlette-datadog Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I think this comment is actually useless (*), and one can see that other comments are wrong (*) and that several components are missing in this list.

(*): always prefer clear naming in code rather than a comment that can become out of sync with the code ;-)

@cbeauchesne cbeauchesne merged commit c5cb2c2 into main Mar 13, 2026
3381 of 3390 checks passed
@cbeauchesne cbeauchesne deleted the xlamorlette/get-nginx-artifact-from-gitlab branch March 13, 2026 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants