[GOLANG] fix(manifests): tighten upper version bounds for WAF blocking tests#6471
Conversation
Running the APPSEC_RASP and APPSEC_RASP_WITHOUT_DOWNSTREAM_BODY_ANALYSIS_USING_SAMPLE_RATE scenarios against the v2.6.0-dev.1 tracer revealed two tests were already passing: - `Test_API10_request_body` - `Test_API10_without_downstream_body_analysis_using_sample_rate` Both were annotated as fixed in `v2.7.0-dev`, but they actually pass with the v2.6.x tracer. Update the manifest entries to `v2.6.0-dev` to reflect the correct first-fix release line. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> JJ-Change-Id: mxsqru
|
|
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🔗 Commit SHA: f428c0d | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback! |
|
Closing — the tests that XPASS'd locally were run against a branch tip ahead of the v2.6.0 stable release. CI with golang@2.6.0 confirms the fix is not yet in the stable release, so v2.7.0-dev remains the correct annotation. |
Testing with v2.6.0-dev.1 showed XPASS, but CI against the stable v2.6.0 release confirmed the fix is not there yet. Restore the original `v2.7.0-dev` annotations for: - `Test_API10_request_body` - `Test_API10_without_downstream_body_analysis_using_sample_rate` Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> JJ-Change-Id: rxqoqv
`test_accept_full_html` and `test_html_template_v2` were marked as bugs for `component_version < 2.7.0`, but the fix for APPSEC-61196 ships in `v2.7.0-dev`. In semver `2.7.0-dev.1 < 2.7.0`, so the dev tracer fell inside the bug range and caused spurious xpasses in the feature parity dashboard. Tighten the upper bound to `< 2.7.0-dev` so that any `2.7.0-dev.*` build is correctly treated as having the fix. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> JJ-Change-Id: nyznqk
RomainMuller
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f428c0da9c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| tests/appsec/waf/test_blocking.py::Test_Blocking::test_accept_full_html: | ||
| - declaration: bug (APPSEC-61196) | ||
| component_version: '<2.7.0' | ||
| component_version: '<2.7.0-dev' |
There was a problem hiding this comment.
This edit tightens the APPSEC-61196 WAF blocking bounds, but it does not update the two API10 entries (Test_API10_request_body and Test_API10_without_downstream_body_analysis_using_sample_rate) that are still pinned to v2.7.0-dev; as a result, APPSEC_RASP runs on v2.6.x will continue to treat those API10 tests as unfixed while this commit introduces an unrelated behavior change for 2.7.0-* pre-releases.
Useful? React with 👍 / 👎.
RomainMuller
deleted the
romain.marcadier/fix-golang-manifest-rasp-versions
branch
2 participants
test_accept_full_html and test_html_template_v2 in Test_Blocking (APPSEC-61196) were annotated as bugs for component_version < 2.7.0. However, the fix ships in v2.7.0-dev, and in semver 2.7.0-dev.1 < 2.7.0 -- so the dev tracer fell inside the bug range and caused spurious xpasses in the feature parity dashboard.
Tightens the upper bound to < 2.7.0-dev so any 2.7.0-dev.* build is correctly treated as having the fix.
Note: the first commit reverts an earlier erroneous change (manifest entries mistakenly lowered to v2.6.0-dev based on a pre-release branch that was ahead of the stable v2.6.0 release).