Skip to content

[cpp] revert skip failing test for APMAPI-1784#6077

Merged
cbeauchesne merged 2 commits intomainfrom
anna/revert-APMAPI-1784
Jan 21, 2026
Merged

[cpp] revert skip failing test for APMAPI-1784#6077
cbeauchesne merged 2 commits intomainfrom
anna/revert-APMAPI-1784

Conversation

@anna-git
Copy link
Contributor

@anna-git anna-git commented Jan 21, 2026

Motivation

Since fix on the tracer-cpp , the test should pass again
Revert of #5942

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@github-actions
Copy link
Contributor

CODEOWNERS have been resolved as:

tests/parametric/test_telemetry.py                                      @DataDog/system-tests-core @DataDog/apm-sdk-capabilities

@anna-git anna-git changed the title bug should be fixed now [cpp] rever skip failing test for APMAPI-1784 Jan 21, 2026
@datadog-official
Copy link

datadog-official bot commented Jan 21, 2026

⚠️ Tests

Fix all issues with Cursor

⚠️ Warnings

❄️ 2 New flaky tests detected

tests.parametric.test_process_discovery.Test_ProcessDiscovery.test_metadata_content_without_process_tags[library_env0, parametric-python] from system_tests_suite (Datadog) (Fix with Cursor)
AssertionError: assert Version('4.3.0-rc1') == Version('4.3.0+rc1')
  Full diff:
  - Version('4.3.0+rc1')
  ?               ^
  + Version('4.3.0-rc1')
  ?               ^

self = <tests.parametric.test_process_discovery.Test_ProcessDiscovery object at 0x7f08488fdb50>
test_library = <utils.docker_fixtures._test_clients._test_client_parametric.ParametricTestClientApi object at 0x7f0813e70a70>
library_env = {'DD_AGENT_HOST': 'localhost', 'DD_ENV': 'second-test', 'DD_EXPERIMENTAL_PROPAGATE_PROCESS_TAGS_ENABLED': 'false', 'DD_SERVICE': 'b', ...}
...
tests.parametric.test_process_discovery.Test_ProcessDiscovery.test_metadata_content_with_process_tags[library_env0, parametric-python] from system_tests_suite (Datadog) (Fix with Cursor)
AssertionError: assert Version('4.3.0-rc1') == Version('4.3.0+rc1')
  Full diff:
  - Version('4.3.0+rc1')
  ?               ^
  + Version('4.3.0-rc1')
  ?               ^

self = <tests.parametric.test_process_discovery.Test_ProcessDiscovery object at 0x7f08488fcbf0>
test_library = <utils.docker_fixtures._test_clients._test_client_parametric.ParametricTestClientApi object at 0x7f0813e72060>
library_env = {'DD_AGENT_HOST': 'localhost', 'DD_ENV': 'test', 'DD_EXPERIMENTAL_PROPAGATE_PROCESS_TAGS_ENABLED': 'true', 'DD_SERVICE': 'a', ...}
...

ℹ️ Info

🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: a42200f | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@anna-git anna-git changed the title [cpp] rever skip failing test for APMAPI-1784 [cpp] revert skip failing test for APMAPI-1784 Jan 21, 2026
@anna-git anna-git marked this pull request as ready for review January 21, 2026 10:55
@anna-git anna-git requested review from a team as code owners January 21, 2026 10:55
@anna-git anna-git requested review from vpellan and removed request for a team January 21, 2026 10:55
@anna-git anna-git enabled auto-merge (squash) January 21, 2026 13:42
@anna-git anna-git disabled auto-merge January 21, 2026 13:42
@cbeauchesne cbeauchesne merged commit 3b91314 into main Jan 21, 2026
1577 of 1585 checks passed
@cbeauchesne cbeauchesne deleted the anna/revert-APMAPI-1784 branch January 21, 2026 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants