mark protobufjs as a dependency#30
Open
matiasgarcia wants to merge 1 commit into
Open
Conversation
tomas2204
approved these changes
Oct 22, 2025
murilonakano
approved these changes
Oct 22, 2025
aandrade4
approved these changes
Oct 22, 2025
diegosolo
approved these changes
Oct 22, 2025
|
This PR shouldn't be merged, and really should be closed, Protobufjs is intentionally not included because it is not a feature which everyone will use. It mentions this right at the start of the readme:
And a bunch of work was done to make sure it doesn't leak into everyone's code #19 - I've been using the library just fine without the protobufjs module included, so it may be specific to your build system? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #26
Fixes this error when importing datadog without the dependency: