Unify StopImpl and StopAndCollectImpl via StopCore template#293
Closed
Unify StopImpl and StopAndCollectImpl via StopCore template#293
Conversation
Extract the common setup and teardown logic from both Stop methods into a single StopCore template method that accepts a callable for the profile-building step. The two public methods become thin wrappers. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Overall package sizeSelf size: 1.98 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | source-map | 0.7.6 | 185.63 kB | 185.63 kB | | pprof-format | 2.2.1 | 163.06 kB | 163.06 kB | | p-limit | 3.1.0 | 7.75 kB | 13.78 kB | | node-gyp-build | 3.9.0 | 8.81 kB | 8.81 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
BenchmarksBenchmark execution time: 2026-03-09 14:43:20 Comparing candidate commit 7994296 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 87 metrics, 33 unstable metrics. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StopImplandStopAndCollectImplinto a singleStopCoretemplate methodStopCoreaccepts a callable for the profile-building step, which is the only part that differs between the two methodsStopImplandStopAndCollectImplbecome thin wrappers (~10–15 lines each)Test plan
npm run build)🤖 Generated with Claude Code