feat(otlp-metrics): added support for histogram, exp. histogram, and summary#1853
Open
feat(otlp-metrics): added support for histogram, exp. histogram, and summary#1853
Conversation
Merged
4 tasks
lucastemb
force-pushed
the
lt/add-otlp-metrics
branch
from
512959a to
5bc3dc5
Compare
lucastemb
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 37bf8c92cf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e0421e01c1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e5b1c795ed
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…summary (#1853) …m, and summary metrics Adds support for the remaining OTLP metrics (Exponential Histogram, Histogram, and Summary) in the correctness tests Will be used to test whether these metric types are being properly handled by ADP in the Saluki repo. A list of issues either fixed, containing architectural discussions, otherwise relevant for this Pull Request. Anything else we should know when reviewing? Original commits: * 460ec05 feat(OTLP metrics): added support for histogram, exponential histogram, and summary metrics * 7cfd22e chore(otlp metrics): changed some params and ran cargo fmt * d398476 test(otlp metrics): added further coverage for the correctness tests * 892cf93 fix(otlp metrics): added quick patch to fix issue of duplicate bins * b02dfdd style(OTLP metrics): applied brief clippy change * b2e3f1c style(otlp metrics): added line to bypass too many lines to abide by existing conventions * 5bc3dc5 chore(otlp metrics): added descriptors to CHANGELOG.md * ebd65a0 fix(otlp metric): removed accidental proptest regression seed file * 37bf8c9 fix(otlp metrics): restore entropy in histogram metric payloads * e0421e0 fix(otlp metrics): addressed codex comments about improper construction of summary metrics * e5b1c79 refactor(otlp): trim scaffolding for new metrics * 75669c1 refactor(otlp-metrics): removed synthetic labels and redundant tests * 782831c chore(otlp-metrics): updated vulnerable dependencies * b7a0e27 Merge branch 'main' into lt/add-otlp-metrics Signed-off-by: Lucas Tembras <lucas.tembras@datadoghq.com>
lucastemb
force-pushed
the
lt/add-otlp-metrics
branch
from
b7a0e27 to
996be2d
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 996be2d185
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2a1274bcff
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f40bd8983b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: be7e11b3d0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 002ae344dc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cb9ff1c104
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fc7b3305f0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Sample the full weighted range
When metric templates sample total_data_points, the loop invariant guarantees current <= max, so current..=current.min(max) is always a single-value range. This helper therefore only returns 1, 2, 4, 8, etc. instead of the documented exponentially weighted buckets like 2-3 and 4-7, which skews generated payload shapes and leaves most point counts in the configured 1-60 range unexercised.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f908b87b17
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 31d4db8537
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 228bef9f8b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1af42fdc6d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
lucastemb
added a commit
to DataDog/saluki
that referenced
this pull request
Apr 27, 2026
…togram (#1319) ## Summary <!-- Please provide a brief summary about what this PR does. This should help the reviewers give feedback faster and with higher quality. --> This PR adds supports for the remaining open telemetry metrics (summary, histogram, and exponential histogram). ## Change Type - [ ] Bug fix - [x] New feature - [ ] Non-functional (chore, refactoring, docs) - [ ] Performance ## How did you test this PR? I created a [draft PR in the lading repo](DataDog/lading#1853) that included the appropriate changes to emit the newly added metrics. I had my `Cargo.toml` point to the branch and ran `make build-datadog-intake-image build-millstone-image build-datadog-agent-image` and `make test-correctness` which yielded the following results: ```rust [*] Running 'dsd-plain' correctness test case... 2026-04-07T20:52:54.164747Z INFO ground_truth: Loaded test case configuration from '/Users/lucas.tembras/saluki/test/correctness/dsd-plain/config.yaml'. 2026-04-07T20:52:54.164804Z INFO ground_truth: Test run starting... 2026-04-07T20:52:54.164890Z INFO ground_truth::runner: Spawning containers for baseline and comparison targets... 2026-04-07T20:52:54.164904Z INFO ground_truth::runner: Creating test group runner for target 'baseline'. Logs will be saved to /tmp/ground-truth/QC8smTa1 2026-04-07T20:52:54.165404Z INFO ground_truth::runner: Creating test group runner for target 'comparison'. Logs will be saved to /tmp/ground-truth/sTsNyjwJ 2026-04-07T20:53:17.025257Z INFO ground_truth::runner: Containers spawned successfully. Waiting for data... 2026-04-07T20:53:54.665292Z INFO ground_truth::runner: Cleaning up remaining containers and resources... 2026-04-07T20:53:56.963274Z INFO ground_truth::runner: Cleanup complete. 2026-04-07T20:53:56.963322Z INFO ground_truth: Test run complete. Analyzing results... 2026-04-07T20:53:56.974946Z INFO ground_truth::analysis::metrics: Analyzing 3095 unfiltered metrics from baseline target, and 3095 unfiltered metrics from comparison target. 2026-04-07T20:53:56.979673Z INFO ground_truth::analysis::metrics: Filtered 67 internal telemetry metric(s) from baseline, and 67 internal telemetry metric(s) from comparison. 2026-04-07T20:53:56.981558Z INFO ground_truth::analysis::metrics: Baseline and comparison both emitted the same set of 3028 unique metrics. Continuing... 2026-04-07T20:53:56.984571Z INFO ground_truth: Analysis complete: no difference detected between baseline and comparison. 2026-04-07T20:53:56.984586Z INFO ground_truth: ground-truth stopped. [*] Running 'dsd-origin-detection' correctness test case... 2026-04-07T20:53:57.600962Z INFO ground_truth: Loaded test case configuration from '/Users/lucas.tembras/saluki/test/correctness/dsd-origin-detection/config.yaml'. 2026-04-07T20:53:57.600989Z INFO ground_truth: Test run starting... 2026-04-07T20:53:57.601028Z INFO ground_truth::runner: Spawning containers for baseline and comparison targets... 2026-04-07T20:53:57.601036Z INFO ground_truth::runner: Creating test group runner for target 'baseline'. Logs will be saved to /tmp/ground-truth/Ulzgl0hU 2026-04-07T20:53:57.601180Z INFO ground_truth::runner: Creating test group runner for target 'comparison'. Logs will be saved to /tmp/ground-truth/hJrERcxw 2026-04-07T20:54:17.630782Z INFO ground_truth::runner: Containers spawned successfully. Waiting for data... 2026-04-07T20:54:54.133377Z INFO ground_truth::runner: Cleaning up remaining containers and resources... 2026-04-07T20:54:56.431092Z INFO ground_truth::runner: Cleanup complete. 2026-04-07T20:54:56.431109Z INFO ground_truth: Test run complete. Analyzing results... 2026-04-07T20:54:56.437142Z INFO ground_truth::analysis::metrics: Analyzing 3095 unfiltered metrics from baseline target, and 3095 unfiltered metrics from comparison target. 2026-04-07T20:54:56.440374Z INFO ground_truth::analysis::metrics: Filtered 67 internal telemetry metric(s) from baseline, and 67 internal telemetry metric(s) from comparison. 2026-04-07T20:54:56.442996Z INFO ground_truth::analysis::metrics: Baseline and comparison both emitted the same set of 3028 unique metrics. Continuing... 2026-04-07T20:54:56.447243Z INFO ground_truth: Analysis complete: no difference detected between baseline and comparison. 2026-04-07T20:54:56.447257Z INFO ground_truth: ground-truth stopped. [*] Running 'otlp-metrics' correctness test case... 2026-04-07T20:54:57.125483Z INFO ground_truth: Loaded test case configuration from '/Users/lucas.tembras/saluki/test/correctness/otlp-metrics/config.yaml'. 2026-04-07T20:54:57.125510Z INFO ground_truth: Test run starting... 2026-04-07T20:54:57.125550Z INFO ground_truth::runner: Spawning containers for baseline and comparison targets... 2026-04-07T20:54:57.125558Z INFO ground_truth::runner: Creating test group runner for target 'baseline'. Logs will be saved to /tmp/ground-truth/7S9Ofk63 2026-04-07T20:54:57.125678Z INFO ground_truth::runner: Creating test group runner for target 'comparison'. Logs will be saved to /tmp/ground-truth/3A4ZVXYw 2026-04-07T20:55:17.473838Z INFO ground_truth::runner: Containers spawned successfully. Waiting for data... 2026-04-07T20:55:58.954998Z INFO ground_truth::runner: Cleaning up remaining containers and resources... 2026-04-07T20:56:01.257443Z INFO ground_truth::runner: Cleanup complete. 2026-04-07T20:56:01.257478Z INFO ground_truth: Test run complete. Analyzing results... 2026-04-07T20:56:01.980027Z INFO ground_truth::analysis::metrics: Analyzing 3106 unfiltered metrics from baseline target, and 3104 unfiltered metrics from comparison target. 2026-04-07T20:56:02.014712Z INFO ground_truth::analysis::metrics: Filtered 69 internal telemetry metric(s) from baseline, and 67 internal telemetry metric(s) from comparison. 2026-04-07T20:56:02.019094Z INFO ground_truth::analysis::metrics: Baseline and comparison both emitted the same set of 3037 unique metrics. Continuing... 2026-04-07T20:56:02.241589Z INFO ground_truth: Analysis complete: no difference detected between baseline and comparison. 2026-04-07T20:56:02.241605Z INFO ground_truth: ground-truth stopped. [*] Running 'otlp-traces' correctness test case... 2026-04-07T20:56:03.007379Z INFO ground_truth: Loaded test case configuration from '/Users/lucas.tembras/saluki/test/correctness/otlp-traces/config.yaml'. 2026-04-07T20:56:03.007406Z INFO ground_truth: Test run starting... 2026-04-07T20:56:03.007444Z INFO ground_truth::runner: Spawning containers for baseline and comparison targets... 2026-04-07T20:56:03.007451Z INFO ground_truth::runner: Creating test group runner for target 'baseline'. Logs will be saved to /tmp/ground-truth/1cVwBPah 2026-04-07T20:56:03.007577Z INFO ground_truth::runner: Creating test group runner for target 'comparison'. Logs will be saved to /tmp/ground-truth/wUNiWwV6 2026-04-07T20:56:23.276549Z INFO ground_truth::runner: Containers spawned successfully. Waiting for data... 2026-04-07T20:57:03.869534Z INFO ground_truth::runner: Cleaning up remaining containers and resources... 2026-04-07T20:57:06.178544Z INFO ground_truth::runner: Cleanup complete. 2026-04-07T20:57:06.178560Z INFO ground_truth: Test run complete. Analyzing results... 2026-04-07T20:57:06.184466Z INFO ground_truth::analysis::traces: Analyzing 2000 traces (4096 spans) from baseline and comparison target. 2026-04-07T20:57:06.234992Z INFO ground_truth::analysis::traces: Analyzing 52 aggregated statistics groups from baseline and comparison target. 2026-04-07T20:57:06.239324Z INFO ground_truth: Analysis complete: no difference detected between baseline and comparison. 2026-04-07T20:57:06.239335Z INFO ground_truth: ground-truth stopped. [*] Running 'otlp-traces-ottl-filtering' correctness test case... 2026-04-07T20:57:06.278783Z INFO ground_truth: Loaded test case configuration from '/Users/lucas.tembras/saluki/test/correctness/otlp-traces-ottl-filtering/config.yaml'. 2026-04-07T20:57:06.278797Z INFO ground_truth: Test run starting... 2026-04-07T20:57:06.278819Z INFO ground_truth::runner: Spawning containers for baseline and comparison targets... 2026-04-07T20:57:06.278822Z INFO ground_truth::runner: Creating test group runner for target 'baseline'. Logs will be saved to /tmp/ground-truth/ygy0OQ1f 2026-04-07T20:57:06.278939Z INFO ground_truth::runner: Creating test group runner for target 'comparison'. Logs will be saved to /tmp/ground-truth/AmhuzMjv 2026-04-07T20:57:39.420798Z INFO ground_truth::runner: Containers spawned successfully. Waiting for data... 2026-04-07T20:58:13.764492Z INFO ground_truth::runner: Cleaning up remaining containers and resources... 2026-04-07T20:58:16.096143Z INFO ground_truth::runner: Cleanup complete. 2026-04-07T20:58:16.096210Z INFO ground_truth: Test run complete. Analyzing results... 2026-04-07T20:58:16.105198Z INFO ground_truth::analysis::traces: Analyzing 1000 traces (2096 spans) from baseline and comparison target. 2026-04-07T20:58:16.141387Z INFO ground_truth: Analysis complete: no difference detected between baseline and comparison. 2026-04-07T20:58:16.141407Z INFO ground_truth: ground-truth stopped. [*] Running 'otlp-traces-ottl-transform' correctness test case... 2026-04-07T20:58:16.812249Z INFO ground_truth: Loaded test case configuration from '/Users/lucas.tembras/saluki/test/correctness/otlp-traces-ottl-transform/config.yaml'. 2026-04-07T20:58:16.812272Z INFO ground_truth: Test run starting... 2026-04-07T20:58:16.812303Z INFO ground_truth::runner: Spawning containers for baseline and comparison targets... 2026-04-07T20:58:16.812308Z INFO ground_truth::runner: Creating test group runner for target 'baseline'. Logs will be saved to /tmp/ground-truth/DCexIxKF 2026-04-07T20:58:16.812427Z INFO ground_truth::runner: Creating test group runner for target 'comparison'. Logs will be saved to /tmp/ground-truth/6KiZgYPM 2026-04-07T20:58:51.020236Z INFO ground_truth::runner: Containers spawned successfully. Waiting for data... 2026-04-07T20:59:33.373262Z INFO ground_truth::runner: Cleaning up remaining containers and resources... 2026-04-07T20:59:35.683447Z INFO ground_truth::runner: Cleanup complete. 2026-04-07T20:59:35.683463Z INFO ground_truth: Test run complete. Analyzing results... 2026-04-07T20:59:35.688473Z INFO ground_truth::analysis::traces: Analyzing 2000 traces (4096 spans) from baseline and comparison target. 2026-04-07T20:59:35.745793Z INFO ground_truth: Analysis complete: no difference detected between baseline and comparison. 2026-04-07T20:59:35.745809Z INFO ground_truth: ground-truth stopped. ``` ## References <!-- Please list any issues closed by this PR. --> <!-- - Closes: <issue link> --> <!-- Any other issues or PRs relevant to this PR? Feel free to list them here. --> --------- Signed-off-by: Lucas Tembras <lucas.tembras@datadoghq.com>
dd-octo-sts Bot
pushed a commit
to DataDog/saluki
that referenced
this pull request
Apr 27, 2026
…togram (#1319) ## Summary <!-- Please provide a brief summary about what this PR does. This should help the reviewers give feedback faster and with higher quality. --> This PR adds supports for the remaining open telemetry metrics (summary, histogram, and exponential histogram). ## Change Type - [ ] Bug fix - [x] New feature - [ ] Non-functional (chore, refactoring, docs) - [ ] Performance ## How did you test this PR? I created a [draft PR in the lading repo](DataDog/lading#1853) that included the appropriate changes to emit the newly added metrics. I had my `Cargo.toml` point to the branch and ran `make build-datadog-intake-image build-millstone-image build-datadog-agent-image` and `make test-correctness` which yielded the following results: ```rust [*] Running 'dsd-plain' correctness test case... 2026-04-07T20:52:54.164747Z INFO ground_truth: Loaded test case configuration from '/Users/lucas.tembras/saluki/test/correctness/dsd-plain/config.yaml'. 2026-04-07T20:52:54.164804Z INFO ground_truth: Test run starting... 2026-04-07T20:52:54.164890Z INFO ground_truth::runner: Spawning containers for baseline and comparison targets... 2026-04-07T20:52:54.164904Z INFO ground_truth::runner: Creating test group runner for target 'baseline'. Logs will be saved to /tmp/ground-truth/QC8smTa1 2026-04-07T20:52:54.165404Z INFO ground_truth::runner: Creating test group runner for target 'comparison'. Logs will be saved to /tmp/ground-truth/sTsNyjwJ 2026-04-07T20:53:17.025257Z INFO ground_truth::runner: Containers spawned successfully. Waiting for data... 2026-04-07T20:53:54.665292Z INFO ground_truth::runner: Cleaning up remaining containers and resources... 2026-04-07T20:53:56.963274Z INFO ground_truth::runner: Cleanup complete. 2026-04-07T20:53:56.963322Z INFO ground_truth: Test run complete. Analyzing results... 2026-04-07T20:53:56.974946Z INFO ground_truth::analysis::metrics: Analyzing 3095 unfiltered metrics from baseline target, and 3095 unfiltered metrics from comparison target. 2026-04-07T20:53:56.979673Z INFO ground_truth::analysis::metrics: Filtered 67 internal telemetry metric(s) from baseline, and 67 internal telemetry metric(s) from comparison. 2026-04-07T20:53:56.981558Z INFO ground_truth::analysis::metrics: Baseline and comparison both emitted the same set of 3028 unique metrics. Continuing... 2026-04-07T20:53:56.984571Z INFO ground_truth: Analysis complete: no difference detected between baseline and comparison. 2026-04-07T20:53:56.984586Z INFO ground_truth: ground-truth stopped. [*] Running 'dsd-origin-detection' correctness test case... 2026-04-07T20:53:57.600962Z INFO ground_truth: Loaded test case configuration from '/Users/lucas.tembras/saluki/test/correctness/dsd-origin-detection/config.yaml'. 2026-04-07T20:53:57.600989Z INFO ground_truth: Test run starting... 2026-04-07T20:53:57.601028Z INFO ground_truth::runner: Spawning containers for baseline and comparison targets... 2026-04-07T20:53:57.601036Z INFO ground_truth::runner: Creating test group runner for target 'baseline'. Logs will be saved to /tmp/ground-truth/Ulzgl0hU 2026-04-07T20:53:57.601180Z INFO ground_truth::runner: Creating test group runner for target 'comparison'. Logs will be saved to /tmp/ground-truth/hJrERcxw 2026-04-07T20:54:17.630782Z INFO ground_truth::runner: Containers spawned successfully. Waiting for data... 2026-04-07T20:54:54.133377Z INFO ground_truth::runner: Cleaning up remaining containers and resources... 2026-04-07T20:54:56.431092Z INFO ground_truth::runner: Cleanup complete. 2026-04-07T20:54:56.431109Z INFO ground_truth: Test run complete. Analyzing results... 2026-04-07T20:54:56.437142Z INFO ground_truth::analysis::metrics: Analyzing 3095 unfiltered metrics from baseline target, and 3095 unfiltered metrics from comparison target. 2026-04-07T20:54:56.440374Z INFO ground_truth::analysis::metrics: Filtered 67 internal telemetry metric(s) from baseline, and 67 internal telemetry metric(s) from comparison. 2026-04-07T20:54:56.442996Z INFO ground_truth::analysis::metrics: Baseline and comparison both emitted the same set of 3028 unique metrics. Continuing... 2026-04-07T20:54:56.447243Z INFO ground_truth: Analysis complete: no difference detected between baseline and comparison. 2026-04-07T20:54:56.447257Z INFO ground_truth: ground-truth stopped. [*] Running 'otlp-metrics' correctness test case... 2026-04-07T20:54:57.125483Z INFO ground_truth: Loaded test case configuration from '/Users/lucas.tembras/saluki/test/correctness/otlp-metrics/config.yaml'. 2026-04-07T20:54:57.125510Z INFO ground_truth: Test run starting... 2026-04-07T20:54:57.125550Z INFO ground_truth::runner: Spawning containers for baseline and comparison targets... 2026-04-07T20:54:57.125558Z INFO ground_truth::runner: Creating test group runner for target 'baseline'. Logs will be saved to /tmp/ground-truth/7S9Ofk63 2026-04-07T20:54:57.125678Z INFO ground_truth::runner: Creating test group runner for target 'comparison'. Logs will be saved to /tmp/ground-truth/3A4ZVXYw 2026-04-07T20:55:17.473838Z INFO ground_truth::runner: Containers spawned successfully. Waiting for data... 2026-04-07T20:55:58.954998Z INFO ground_truth::runner: Cleaning up remaining containers and resources... 2026-04-07T20:56:01.257443Z INFO ground_truth::runner: Cleanup complete. 2026-04-07T20:56:01.257478Z INFO ground_truth: Test run complete. Analyzing results... 2026-04-07T20:56:01.980027Z INFO ground_truth::analysis::metrics: Analyzing 3106 unfiltered metrics from baseline target, and 3104 unfiltered metrics from comparison target. 2026-04-07T20:56:02.014712Z INFO ground_truth::analysis::metrics: Filtered 69 internal telemetry metric(s) from baseline, and 67 internal telemetry metric(s) from comparison. 2026-04-07T20:56:02.019094Z INFO ground_truth::analysis::metrics: Baseline and comparison both emitted the same set of 3037 unique metrics. Continuing... 2026-04-07T20:56:02.241589Z INFO ground_truth: Analysis complete: no difference detected between baseline and comparison. 2026-04-07T20:56:02.241605Z INFO ground_truth: ground-truth stopped. [*] Running 'otlp-traces' correctness test case... 2026-04-07T20:56:03.007379Z INFO ground_truth: Loaded test case configuration from '/Users/lucas.tembras/saluki/test/correctness/otlp-traces/config.yaml'. 2026-04-07T20:56:03.007406Z INFO ground_truth: Test run starting... 2026-04-07T20:56:03.007444Z INFO ground_truth::runner: Spawning containers for baseline and comparison targets... 2026-04-07T20:56:03.007451Z INFO ground_truth::runner: Creating test group runner for target 'baseline'. Logs will be saved to /tmp/ground-truth/1cVwBPah 2026-04-07T20:56:03.007577Z INFO ground_truth::runner: Creating test group runner for target 'comparison'. Logs will be saved to /tmp/ground-truth/wUNiWwV6 2026-04-07T20:56:23.276549Z INFO ground_truth::runner: Containers spawned successfully. Waiting for data... 2026-04-07T20:57:03.869534Z INFO ground_truth::runner: Cleaning up remaining containers and resources... 2026-04-07T20:57:06.178544Z INFO ground_truth::runner: Cleanup complete. 2026-04-07T20:57:06.178560Z INFO ground_truth: Test run complete. Analyzing results... 2026-04-07T20:57:06.184466Z INFO ground_truth::analysis::traces: Analyzing 2000 traces (4096 spans) from baseline and comparison target. 2026-04-07T20:57:06.234992Z INFO ground_truth::analysis::traces: Analyzing 52 aggregated statistics groups from baseline and comparison target. 2026-04-07T20:57:06.239324Z INFO ground_truth: Analysis complete: no difference detected between baseline and comparison. 2026-04-07T20:57:06.239335Z INFO ground_truth: ground-truth stopped. [*] Running 'otlp-traces-ottl-filtering' correctness test case... 2026-04-07T20:57:06.278783Z INFO ground_truth: Loaded test case configuration from '/Users/lucas.tembras/saluki/test/correctness/otlp-traces-ottl-filtering/config.yaml'. 2026-04-07T20:57:06.278797Z INFO ground_truth: Test run starting... 2026-04-07T20:57:06.278819Z INFO ground_truth::runner: Spawning containers for baseline and comparison targets... 2026-04-07T20:57:06.278822Z INFO ground_truth::runner: Creating test group runner for target 'baseline'. Logs will be saved to /tmp/ground-truth/ygy0OQ1f 2026-04-07T20:57:06.278939Z INFO ground_truth::runner: Creating test group runner for target 'comparison'. Logs will be saved to /tmp/ground-truth/AmhuzMjv 2026-04-07T20:57:39.420798Z INFO ground_truth::runner: Containers spawned successfully. Waiting for data... 2026-04-07T20:58:13.764492Z INFO ground_truth::runner: Cleaning up remaining containers and resources... 2026-04-07T20:58:16.096143Z INFO ground_truth::runner: Cleanup complete. 2026-04-07T20:58:16.096210Z INFO ground_truth: Test run complete. Analyzing results... 2026-04-07T20:58:16.105198Z INFO ground_truth::analysis::traces: Analyzing 1000 traces (2096 spans) from baseline and comparison target. 2026-04-07T20:58:16.141387Z INFO ground_truth: Analysis complete: no difference detected between baseline and comparison. 2026-04-07T20:58:16.141407Z INFO ground_truth: ground-truth stopped. [*] Running 'otlp-traces-ottl-transform' correctness test case... 2026-04-07T20:58:16.812249Z INFO ground_truth: Loaded test case configuration from '/Users/lucas.tembras/saluki/test/correctness/otlp-traces-ottl-transform/config.yaml'. 2026-04-07T20:58:16.812272Z INFO ground_truth: Test run starting... 2026-04-07T20:58:16.812303Z INFO ground_truth::runner: Spawning containers for baseline and comparison targets... 2026-04-07T20:58:16.812308Z INFO ground_truth::runner: Creating test group runner for target 'baseline'. Logs will be saved to /tmp/ground-truth/DCexIxKF 2026-04-07T20:58:16.812427Z INFO ground_truth::runner: Creating test group runner for target 'comparison'. Logs will be saved to /tmp/ground-truth/6KiZgYPM 2026-04-07T20:58:51.020236Z INFO ground_truth::runner: Containers spawned successfully. Waiting for data... 2026-04-07T20:59:33.373262Z INFO ground_truth::runner: Cleaning up remaining containers and resources... 2026-04-07T20:59:35.683447Z INFO ground_truth::runner: Cleanup complete. 2026-04-07T20:59:35.683463Z INFO ground_truth: Test run complete. Analyzing results... 2026-04-07T20:59:35.688473Z INFO ground_truth::analysis::traces: Analyzing 2000 traces (4096 spans) from baseline and comparison target. 2026-04-07T20:59:35.745793Z INFO ground_truth: Analysis complete: no difference detected between baseline and comparison. 2026-04-07T20:59:35.745809Z INFO ground_truth: ground-truth stopped. ``` ## References <!-- Please list any issues closed by this PR. --> <!-- - Closes: <issue link> --> <!-- Any other issues or PRs relevant to this PR? Feel free to list them here. --> --------- Signed-off-by: Lucas Tembras <lucas.tembras@datadoghq.com> 7ce97ac
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…m, and summary metrics
What does this PR do?
Adds support for the remaining OTLP metrics (Exponential Histogram, Histogram, and Summary) in the correctness tests.
Motivation
Will be used to test whether these metric types are being properly handled by ADP in the Saluki repo when compared to the Agent.
Supports:
Related issues
A list of issues either fixed, containing architectural discussions, otherwise relevant
for this Pull Request.
Additional Notes
Anything else we should know when reviewing?
Listed below is some additional information for the metrics added (how they are constructed and how they are expected to behave):