Skip to content

fix(rum): process the result of calling injector_end#28

Draft
pablomartinezbernardo wants to merge 1 commit intomainfrom
pmartinez/injector-end
Draft

fix(rum): process the result of calling injector_end#28
pablomartinezbernardo wants to merge 1 commit intomainfrom
pmartinez/injector-end

Conversation

@pablomartinezbernardo
Copy link
Contributor

@pablomartinezbernardo pablomartinezbernardo commented Jun 11, 2025

Changes in the internals for the injection library uncovered a bug where the result of calling injector_end were never considered.

This PR fixes that by

  • Keeping behavior if injector_end doesn't result in injection
  • Creating a new bucket brigade with a single bucket to override all the content of the response

@pablomartinezbernardo pablomartinezbernardo changed the title Process the result of calling injector_end fix(rum): process the result of calling injector_end Jun 11, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jun 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.70%. Comparing base (cdb3cb2) to head (c37b805).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #28   +/-   ##
=======================================
  Coverage   62.70%   62.70%           
=======================================
  Files           7        7           
  Lines         370      370           
  Branches       49       49           
=======================================
  Hits          232      232           
  Misses        100      100           
  Partials       38       38           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants