ci: fix Windows job flakiness caused by dirty workspace

[Leiyks]

Summary

Fixes Windows CI job flakiness caused by leftover files from previous runs on persistent Windows runners.

Root causes fixed:

• x64/Release/php_ddtrace.dll / .pdb: NTFS junction points/reparse points that PS 5.1 Remove-Item -Recurse and git checkout can't remove, causing git checkout to fail with "Invalid argument"
• run-tests.php and PHP test files: held open with "Permission Denied" by previous job's processes
• Docker containers from previous runs holding php_ddtrace.dll open across jobs

Solution:

• Extracted shared windows_git_setup() function in generate-common.php used by all three affected Windows jobs
• Kills leftover Docker containers before cleanup
• Uses cmd.exe rd /s /q from the parent directory (handles junction points that PS 5.1 can't)
• Manual git clone + git checkout with $LASTEXITCODE guards (PS 5.1 ignores $PSNativeCommandUseErrorActionPreference)
• All three jobs now use GIT_STRATEGY: none to skip GitLab's built-in checkout

Jobs fixed:

• compile extension windows (generate-package.php)
• windows test_c (generate-tracer.php)
• verify windows (generate-package.php) — uses a variant windows_git_setup_with_packages() that saves/restores the packages/ artifact around the workspace wipe

[datadog-official]

⚠️ Tests

✨ Fix all issues with BitsAI or with Cursor

⚠️ Warnings

🧪 1028 Tests failed

testSearchPhpBinaries from integration.DDTrace\Tests\Integration\PHPInstallerTest (Datadog) (Fix with Cursor)

DDTrace\Tests\Integration\PHPInstallerTest::testSearchPhpBinaries
Test code or tested code printed unexpected output: Searching for available php binaries, this operation might take a while.

testSimplePushAndProcess from laravel-58-test.DDTrace\Tests\Integrations\Laravel\V5_8\QueueTest (Datadog) (Fix with Cursor)

DDTrace\Tests\Integrations\Laravel\V5_8\QueueTest::testSimplePushAndProcess
Test code or tested code printed unexpected output: spanLinksTraceId: 69b2ea3b00000000046f2ca99853ebe0
tid: 69b2ea3b00000000
hexProcessTraceId: 046f2ca99853ebe0
hexProcessSpanId: df86221a5e291fd3
processTraceId: 319523205483326432
processSpanId: 16106598613981405139

phpvfscomposer://tests/vendor/phpunit/phpunit/phpunit:106

testSimplePushAndProcess from laravel-8x-test.DDTrace\Tests\Integrations\Laravel\V8_x\QueueTest (Datadog) (Fix with Cursor)

DDTrace\Tests\Integrations\Laravel\V8_x\QueueTest::testSimplePushAndProcess
Test code or tested code printed unexpected output: spanLinksTraceId: 69b2ea6a00000000c578b57468a1d1af
tid: 69b2ea6a00000000
hexProcessTraceId: c578b57468a1d1af
hexProcessSpanId: bfc8cd46aa21d8b7
processTraceId: 14229322534253351343
processSpanId: 13819521159972116663

View all

ℹ️ Info

No other issues found (see more)

❄️ No new flaky tests detected

_{This comment will be updated automatically if new data arrives.
🔗 Commit SHA: b0d2cde | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!}

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.30%. Comparing base (7d767af) to head (b0d2cde).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3694      +/-   ##
==========================================
- Coverage   62.40%   62.30%   -0.11%     
==========================================
  Files         142      142              
  Lines       13586    13586              
  Branches     1775     1775              
==========================================
- Hits         8479     8465      -14     
- Misses       4301     4314      +13     
- Partials      806      807       +1     

see 3 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d767af...b0d2cde. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.