Skip to content

Adds process tags to remote config payload#3658

Open
dubloom wants to merge 3 commits intomasterfrom
dubloom/process-tags-rc
Open

Adds process tags to remote config payload#3658
dubloom wants to merge 3 commits intomasterfrom
dubloom/process-tags-rc

Conversation

@dubloom
Copy link
Contributor

@dubloom dubloom commented Feb 17, 2026

Description

This PR implements this RFC for Remote Configuration.

Add process_tags to remote configuration payload.

This PR comes with this libdatadog PR: DataDog/libdatadog#1586

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Feb 17, 2026

⚠️ Tests

Fix all issues with BitsAI or with Cursor

⚠️ Warnings

🧪 1030 Tests failed

testSearchPhpBinaries from integration.DDTrace\Tests\Integration\PHPInstallerTest (Datadog) (Fix with Cursor)
Risky Test
phpvfscomposer://tests/vendor/phpunit/phpunit/phpunit:97
testSimplePushAndProcess from laravel-58-test.DDTrace\Tests\Integrations\Laravel\V5_8\QueueTest (Datadog) (Fix with Cursor)
DDTrace\Tests\Integrations\Laravel\V5_8\QueueTest::testSimplePushAndProcess
Test code or tested code printed unexpected output: spanLinksTraceId: 69b001ac000000009a7a8fe7ac414143
tid: 69b001ac00000000
hexProcessTraceId: 9a7a8fe7ac414143
hexProcessSpanId: c08db67767ebe087
processTraceId: 11131367654189777219
processSpanId: 13874946650959241351

phpvfscomposer://tests/vendor/phpunit/phpunit/phpunit:106
testSimplePushAndProcess from laravel-8x-test.DDTrace\Tests\Integrations\Laravel\V8_x\QueueTest (Datadog) (Fix with Cursor)
DDTrace\Tests\Integrations\Laravel\V8_x\QueueTest::testSimplePushAndProcess
Test code or tested code printed unexpected output: spanLinksTraceId: 69b001b10000000076ac276a049fcc2a
tid: 69b001b100000000
hexProcessTraceId: 76ac276a049fcc2a
hexProcessSpanId: f262203a27bef640
processTraceId: 8551253128767327274
processSpanId: 17465557739043223104

phpvfscomposer://tests/vendor/phpunit/phpunit/phpunit:106
View all

ℹ️ Info

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: b30e4f1 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!

@codecov-commenter
Copy link

codecov-commenter commented Feb 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.32%. Comparing base (41b371e) to head (b30e4f1).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3658      +/-   ##
==========================================
- Coverage   62.39%   62.32%   -0.08%     
==========================================
  Files         142      142              
  Lines       13586    13586              
  Branches     1775     1775              
==========================================
- Hits         8477     8467      -10     
- Misses       4304     4311       +7     
- Partials      805      808       +3     

see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41b371e...b30e4f1. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link

pr-commenter bot commented Feb 17, 2026

Benchmarks [ tracer ]

Benchmark execution time: 2026-03-10 14:24:25

Comparing candidate commit b30e4f1 in PR branch dubloom/process-tags-rc with baseline commit 41b371e in branch master.

Found 0 performance improvements and 2 performance regressions! Performance is the same for 190 metrics, 2 unstable metrics.

scenario:ComposerTelemetryBench/benchTelemetryParsing-opcache

  • 🟥 execution_time [+406.753ns; +1393.247ns] or [+3.178%; +10.885%]

scenario:PHPRedisBench/benchRedisOverhead

  • 🟥 execution_time [+55.859µs; +95.161µs] or [+7.053%; +12.015%]

@dubloom dubloom force-pushed the dubloom/process-tags-rc branch 2 times, most recently from af07faf to 2cb6fdb Compare March 10, 2026 09:54
@dubloom dubloom force-pushed the dubloom/process-tags-rc branch from 2cb6fdb to 0a56d4b Compare March 10, 2026 09:56
@dubloom dubloom marked this pull request as ready for review March 10, 2026 10:20
@dubloom dubloom requested review from a team as code owners March 10, 2026 10:20
Copy link
Contributor

@Leiyks Leiyks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants