WORK-IN-PROGRESS feat(lambda): migrate datadog-lambda-js into dd-trace-js as a plugin#7778
Draft
joeyzhao2018 wants to merge 3 commits intomasterfrom
Draft
WORK-IN-PROGRESS feat(lambda): migrate datadog-lambda-js into dd-trace-js as a plugin#7778joeyzhao2018 wants to merge 3 commits intomasterfrom
joeyzhao2018 wants to merge 3 commits intomasterfrom
Conversation
Consolidates all server-side Lambda tracing functionality from the standalone datadog-lambda-js repo into dd-trace-js as a proper plugin, eliminating the double-wrapping problem and using AWS_LAMBDA_EXEC_WRAPPER for clean auto-instrumentation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
joeyzhao2018
requested review from
khanayan123 and
lym953
and removed request for
a team
This comment has been minimized.
This comment has been minimized.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7778 +/- ##
==========================================
- Coverage 80.42% 76.27% -4.16%
==========================================
Files 741 647 -94
Lines 32177 27386 -4791
==========================================
- Hits 25878 20888 -4990
- Misses 6299 6498 +199
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
joeyzhao2018
changed the title
Contributor
Overall package sizeSelf size: 5.06 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.0.0 | 81.15 kB | 815.98 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
The Agent Extension layer ships its own /opt/datadog_wrapper, which overwrites the dd-trace layer's wrapper. Move the wrapper into /opt/nodejs/dd_trace_wrapper to avoid the collision. Also fix handler instrumentation to use Module._load instead of addHook, since the Lambda runtime loads handlers by file path (not npm package name). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
BenchmarksBenchmark execution time: 2026-03-14 04:12:50 Comparing candidate commit b6ed1e9 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 228 metrics, 32 unstable metrics. |
…ixes The nodejs22.x Lambda runtime uses ESM import() to load handlers, which bypasses Module._load patching entirely. Switch to overriding _HANDLER in the wrapper script to point to a handler-wrapper module that loads the original handler, wraps it with tracing channel events, and re-exports it. Also fixes several issues found during real-world Lambda deployment: - Register lambda plugin explicitly in PluginManager (no addHook flow) - Add DD_TRACE_LAMBDA_ENABLED to supported-configurations.json - Add lambda schema to v0/v1 serverless service naming definitions - Don't propagate X-Ray Sampled=0 as sampling priority -1 unless DD_MERGE_XRAY_TRACES is enabled (was dropping all traces) - Wrap asyncStart in try/finally to guarantee span.finish() Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidates all server-side Lambda tracing functionality from the standalone datadog-lambda-js repo into dd-trace-js as a proper plugin, eliminating the double-wrapping problem and using AWS_LAMBDA_EXEC_WRAPPER for clean auto-instrumentation.
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com
What does this PR do?
Motivation
Additional Notes