Conversation
Overall package sizeSelf size: 4.95 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.0.0 | 81.15 kB | 815.98 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
bengl
force-pushed
the
bengl/dd-octo-sts
branch
from
964cfee to
51c2627
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7732 +/- ##
===========================================
+ Coverage 69.93% 80.40% +10.46%
===========================================
Files 711 741 +30
Lines 31177 32084 +907
===========================================
+ Hits 21805 25797 +3992
+ Misses 9372 6287 -3085 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
xopham
left a comment
xopham
left a comment
There was a problem hiding this comment.
I made a few comments to improve this on the publish-v3 job that should if accepted be used for all others as well. Made a brief self-test workflow and run for reference :)
Thanks for fixing!
| claim_pattern: | ||
| event_name: (push|workflow_dispatch) | ||
| ref: refs/heads/(v[345]\.x|master) | ||
| ref_protected: "true" |
There was a problem hiding this comment.
this has turned out to be an unreliable and misleading field, so let's drop it. The plugin is technically instructed to not add it, so i am taking note
| @@ -0,0 +1,13 @@ | |||
| issuer: https://token.actions.githubusercontent.com | |||
There was a problem hiding this comment.
could we name it self.github.release.push-tags.sts.yaml to comply with naming scheme?
| id: octo-sts | ||
| with: | ||
| scope: DataDog/dd-trace-js | ||
| policy: release |
There was a problem hiding this comment.
if adjusted above:
| policy: release | |
| policy: self.github.release.push-tags |
| with: | ||
| scope: DataDog/dd-trace-js | ||
| policy: release | ||
| - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 |
There was a problem hiding this comment.
better than injecting below, you could do:
| - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 | |
| - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 | |
| with: | |
| token: ${{ steps.octo-sts.outputs.token }} |
| - run: | | ||
| git tag v${{ fromJson(steps.pkg.outputs.json).version }} | ||
| git push origin v${{ fromJson(steps.pkg.outputs.json).version }} | ||
| git push https://x-access-token:${{ steps.octo-sts.outputs.token }}@github.com/${{ github.repository }}.git v${{ fromJson(steps.pkg.outputs.json).version }} |
There was a problem hiding this comment.
if adjusting the previous comment, you can go back to:
| git push https://x-access-token:${{ steps.octo-sts.outputs.token }}@github.com/${{ github.repository }}.git v${{ fromJson(steps.pkg.outputs.json).version }} | |
| git push origin v${{ fromJson(steps.pkg.outputs.json).version }} |
| contents: write | ||
| pull-requests: read |
There was a problem hiding this comment.
I am not sure why there ever was a pull-requests: read, but I assume this and the contents: write can be removed:
Unless the npm publish action needs it in which case only drop the contents: write
2 participants
No description provided.