Conversation
dmehala
force-pushed
the
dmehala/no-default-logger
branch
from
49314dc to
e6c5679
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #187 +/- ##
==========================================
- Coverage 93.60% 93.56% -0.05%
==========================================
Files 73 74 +1
Lines 4256 4260 +4
==========================================
+ Hits 3984 3986 +2
- Misses 272 274 +2 ☔ View full report in Codecov by Sentry. |
pablomartinezbernardo
approved these changes
Feb 18, 2025
The library now uses a NullLogger by default if no logger is specified. This means that no logs will be printed unless a customer logger is provided. Author: Damien MEHALA <damien.mehala@datadoghq.com>
dmehala
force-pushed
the
dmehala/no-default-logger
branch
from
e6c5679 to
866dee4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The library now uses a
NullLoggerby default if no logger is specified. This means that no logs will be printed unless a customer logger is provided.Motivation
It’s generally better for a library to not log by default but instead allow the user to configure logging. It avoids unwanted noises, avoids conflicts with application logging and respects user control (the binary using our library should dictate how logs are handled).