fix: Remote config service/env validation#177
Merged
zacharycmontoya merged 2 commits intomainfrom Jan 24, 2025
Merged
Conversation
92bb662 to
7bd282c
Compare
BenchmarksBenchmark execution time: 2025-01-24 17:59:18 Comparing candidate commit 7bd282c in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #177 +/- ##
==========================================
+ Coverage 93.82% 93.90% +0.08%
==========================================
Files 73 73
Lines 4176 4169 -7
==========================================
- Hits 3918 3915 -3
+ Misses 258 254 -4 ☔ View full report in Codecov by Sentry. |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes the remote config check that asserts a matching env / service, as this is incorrectly causing remote config payloads to be ignored
Motivation
This was motivated by a customer issue with adaptive sampling not working. When the tracer doesn't report an environment version but the Datadog agent does, incoming remote config payloads (which have already been verified by the Datadog agent) get rejected even though they are correct. This removes the validation and relies upon the Datadog agent verification.
Testing
The previous unit test has been removed as it's invalid, and the associated system-tests authored here have been tested locally with success: DataDog/system-tests#3778
Additional Notes
Jira ticket: APMAPI-1006