perf: move filter check before deepcopy in _apply_resource_cb#518
Merged
michael-richey merged 1 commit intomainfrom Apr 8, 2026
Merged
perf: move filter check before deepcopy in _apply_resource_cb#518michael-richey merged 1 commit intomainfrom
michael-richey merged 1 commit intomainfrom
Conversation
When syncing with --filter, every resource went through deepcopy and lock acquisition before the filter check discarded it. For orgs with thousands of resources where only a handful match the filter, this wasted significant memory on copies that were immediately thrown away. Move the filter check to run first, before deepcopy and lock.acquire(). Add a lock_acquired boolean to prevent the finally block from releasing an unacquired lock on the early-return path. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
michael-richey
force-pushed
the
perf/filter-before-deepcopy
branch
from
348aba2 to
0887b10
Compare
riyazsh
approved these changes
Apr 7, 2026
nathantournant
approved these changes
Apr 8, 2026
heyronhay
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
filter()check in_apply_resource_cbto run beforedeepcopyandlock.acquire(), so filtered-out resources skip both memory allocation and lock contentionlock_acquiredboolean to guard thefinallyblock'slock.release()call, preventingRuntimeErroron the early-return path for non-concurrent resource typesContext: When syncing with
--filterin orgs with thousands of resources, every resource was deepcopied and the lock was acquired before the filter discarded it. This is the first of a series of filter optimization PRs.Test plan
python -m pytest tests/unit/)🤖 Generated with Claude Code