Skip to content

fix: update trust policy event_name to match push trigger in release workflow#516

Merged
michael-richey merged 2 commits intomainfrom
fix/release-workflow-oidc
Apr 7, 2026
Merged

fix: update trust policy event_name to match push trigger in release workflow#516
michael-richey merged 2 commits intomainfrom
fix/release-workflow-oidc

Conversation

@michael-richey
Copy link
Copy Markdown
Collaborator

Summary

  • The release workflow was switched from pull_request to push trigger (fix: use dd-octo-sts token for tag creation in release workflow #511) to fix an OIDC subject mismatch
  • The trust policy (self.release.create-release.sts.yaml) was not updated to match, causing event_name claim mismatch on every token exchange
  • Updated event_name: pull_requestevent_name: push in claim_pattern
  • Added repository claim for defense in depth
  • Fixed unescaped dots in job_workflow_ref regex pattern
  • Sorted claim_pattern keys alphabetically and updated header comment

Test plan

  • Merge to main
  • Trigger a release by merging a release/vX.Y.Z branch PR to main
  • Confirm the Get access token step succeeds in the release workflow

🤖 Generated with Claude Code

michael-richey and others added 2 commits April 7, 2026 13:41
…ject mismatch

The pull_request trigger sets OIDC sub to
repo:DataDog/datadog-sync-cli:pull_request, which does not match the
self.release.create-release trust policy requiring ref:refs/heads/main.

Switching to a push trigger fixes the subject. A detect_release step
recovers the PR context (branch name, release guard) lost by moving away
from the pull_request event.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…workflow

The release workflow was switched from pull_request to push trigger, but
the trust policy still required event_name: pull_request, causing OIDC
subject mismatch on every token exchange.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@michael-richey michael-richey marked this pull request as ready for review April 7, 2026 19:08
@michael-richey michael-richey requested a review from a team as a code owner April 7, 2026 19:08
@michael-richey michael-richey merged commit 71def87 into main Apr 7, 2026
21 of 22 checks passed
@michael-richey michael-richey deleted the fix/release-workflow-oidc branch April 7, 2026 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants