Skip to content

[SVLS-6465] Make needed modifications to sandbox deploy to apply values to template.yml #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TophrC-dd wants to merge 7 commits into
base: main
Choose a base branch
from
Open

[SVLS-6465] Make needed modifications to sandbox deploy to apply values to template.yml #190

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ed3b766
Fixing the release script to modify the template when deploying to sa…
TophrC-dd Mar 27, 2025
b305428
remove redundant variable
TophrC-dd Mar 27, 2025
e9d1272
enhance readability
TophrC-dd Mar 27, 2025
cabcf6e
fixing escaped characters
TophrC-dd Mar 27, 2025
89a15d4
just passing values through the url params is a less complicated appr…
TophrC-dd Apr 3, 2025
fae90f7
Merge branch 'main' into release-script-fix
TophrC-dd Apr 29, 2025
3ed738b
Merge branch 'main' into release-script-fix
TophrC-dd Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions serverless/release.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,12 +114,13 @@ if [ "$PROD_RELEASE" = true ] ; then
MACRO_SOURCE_URL="https://github.com/DataDog/datadog-cloudformation-macro/releases/download/serverless-macro-${VERSION}/serverless-macro-${VERSION}.zip'"
else
VERSION=${CI_COMMIT_SHA:-$(whoami)}
echo "About to release non-public staging version of macro, upload serverless-macro-${VERSION} to s3, and upload the template.yml to s3://${BUCKET}/aws/serverless-macro-staging/${VERSION}.yml"
MACRO_SOURCE_URL="https://${BUCKET}.s3.amazonaws.com/aws/serverless-macro-staging-zip/serverless-macro-${VERSION}.zip"
TEMPLATE_URL="https://${BUCKET}.s3.amazonaws.com/aws/serverless-macro-staging/latest.yml"

# Upload to s3 instead of github
echo "About to release non-public staging version of macro, upload serverless-macro-${VERSION} to s3, and upload the template.yml to s3://${BUCKET}/aws/serverless-macro-staging/${VERSION}.yml"
tools/build_zip.sh "${VERSION}"
aws s3 cp .macro/serverless-macro-${VERSION}.zip s3://${BUCKET}/aws/serverless-macro-staging-zip/serverless-macro-${VERSION}.zip
TEMPLATE_URL="https://${BUCKET}.s3.amazonaws.com/aws/serverless-macro-staging/latest.yml"
MACRO_SOURCE_URL="s3://${BUCKET}/aws/serverless-macro-staging-zip/serverless-macro-${VERSION}.zip"
fi

# Upload the template to the S3 bucket
Expand All @@ -139,7 +140,7 @@ else
fi

echo "Done uploading the template, and here is the CloudFormation quick launch URL"
echo "https://console.aws.amazon.com/cloudformation/home#/stacks/quickCreate?stackName=datadog-serverless-macro&templateURL=${TEMPLATE_URL}"
echo "https://console.aws.amazon.com/cloudformation/home#/stacks/quickCreate?stackName=datadog-serverless-macro&templateURL=${TEMPLATE_URL}&param_SourceZipUrl=${MACRO_SOURCE_URL}"

echo "Done!"

Expand Down