Conversation
29326d0 to
d9a7e45
Compare
| version: data.version, | ||
| abi: data.modules, | ||
| isNightly: true, | ||
| alpineVersion: data.alpineVersion || '~3.17' |
There was a problem hiding this comment.
Why is this needed? Isn't this version supposed to come from Alpine itself? Especially since we support multiple versions so I'm not sure what this variable does.
There was a problem hiding this comment.
Most targets already have a hardcoded version which is used to filter the nodeTargets array, we could either never add that alpineVersion or leave as the current default that node 25 uses and if needed give the possibility of it being defined by the user.
This would involve adding the following code when pushing the nightly target
if (process.env.NIGHTLY_VERSION) {
const nightlyTarget = await getNightlyTarget()
if (alpineVersion === undefined || semver.satisfies(alpineVersion, nightlyTarget.alpineVersion)) {
filteredTargets.push(nightlyTarget)
}
}
.github/workflows/build.yml
Outdated
| required: false | ||
| type: number | ||
| nightly-versions: | ||
| description: Versions to build again, use 'latest' to use the nightliest node version, for specific version use the following format 'nodeVersion,abiVersion,alpineVersion' |
There was a problem hiding this comment.
Since we already need to pull the ABI version for latest anyway, should it just always be pulled so that it doesn't need to be specified by the user?
There was a problem hiding this comment.
Also, should this be nightly-version since it only contains a single version?
There was a problem hiding this comment.
I wonder if this could be combined with max-node-version too, since they are somewhat in conflict.
There was a problem hiding this comment.
min-node-versions for the most part is only used to filter the already existing node targets, after that if the env for nightly is set then it adds it into the targets array, but it never interact with the constraint that min-node-version adds.
There was a problem hiding this comment.
For the latest thing, we not only need to pull the ABI version but also the full nightly version id which is later on used as the target. If we were to not give the option of the user specifying a version then we would not only default to only the latest nightly but would have to always do a fetch.
This PR intends to add the functionality of pre-building against nightly builds of Node.js.