fix(scan): encrypted/corrupt files → scan_failures (#828 open-core)#1146
Merged
Conversation
Zip/7z member read failures persist encrypted_no_password, wrong_password, or archive_read_error. PDF encrypted without password uses the same taxonomy. Open-core slice; Pro decrypt and plan doc follow in later commits.
Prevent accidental `git add -A` from staging operator drafts or beastie roster scripts. Tracked today-mode hub files on origin remain tracked; add explicitly.
Wire on_read_barrier for archive member text sampling; map Zip Bad CRC-32 to wrong_password; classify py7zr member/open failures with distinct reasons.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| tmp_path, monkeypatch: pytest.MonkeyPatch | ||
| ): | ||
| """Encrypted PDF inside a zip must record scan_failures via on_read_barrier (#828).""" | ||
| import connectors.filesystem_connector as fs_mod |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Open-core slice of #828 (reopened on clean branch after OPSEC rewrite).
scan_failures(encrypted_no_password,wrong_password,archive_read_error)chore(opsec):.gitignoreblocksdocs/ops/today-mode/,beastie-ecosystem-sync.*, mascot draftOPSEC: PR #1145 /
feat/828-scan-failures-encryptedhad accidental private files in commit706277a8(removed in follow-up commit but still in branch history). This PR is history-clean — do not merge #1145; operator should delete remote branchfeat/828-scan-failures-encryptedafter switching here.Test plan
tests/test_archives_scan_failures.py./scripts/check-all.shgreenPartial toward #828. Bugbot follow-ups pending.
Made with Cursor