fix(connector): SQL sampling failures → scan_failures (#1140)#1144
Merged
Conversation
…1140) Sampling query failures now persist sampling_error rows, raise ColumnSampleError, and skip detection instead of returning empty samples that masquerade as clean scans.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Bugbot: full-scan ColumnSampleError must not drop the first-pass DOB_POSSIBLE_MINOR result. Add failure_hint for sampling_error in reports.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
save_failure(..., reason=sampling_error), raiseColumnSampleError, skipscan_columnfor that column.None); only the samplingexecutepath elevates toscan_failures.SCAN_FAILURE_REASON_SAMPLING_ERROR+format_column_sample_failure_details()for the shared [P1·G3·U1] feat/fix(scan): arquivo cifrado/corrompido vira 'limpo' silencioso — distinguir 5 estados em scan_failures (open-core) + ler-dentro (Pro) #828 taxonomy (filesystem twin).Test plan
test_sql_connector_sample_syntax_error_records_scan_failure—ProgrammingError→save_failure+ColumnSampleErrortest_process_one_finding_sampling_error_skips_scan_column— no false-clean detection./scripts/check-all.shgreenNão-fazer (per issue)
OPTIONclause reinvention — timeout stays connection-levelCloses #1140
Made with Cursor