Repository navigation
Release/3.5.2 - #22
Merged
Merged
Conversation
Replace hard subList indices in CreatePdf with drop/take so journal headers with fewer than 6 lines (e.g. proforma receipts) no longer throw IndexOutOfBoundsException on print. Add temporary [DEBUG-pdf] logging to Logcat and Crashlytics to identify the malformed journal shape. Bump version to 3.5.2. Claude-Session: https://claude.ai/code/session_01MqPHhmoisS6SCg3E6umn2L
Send the PDF journal diagnostics to Crashlytics as a non-fatal only when the journal is malformed, include receipt content in the log solely on that path, and remove CLAUDE.md from version control. Claude-Session: https://claude.ai/code/session_01MqPHhmoisS6SCg3E6umn2L
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IndexOutOfBoundsException: toIndex = 6in PDF creation when printing invoices whose journal header block has fewer than 6 lines (seen with proforma receipts).drop/takeinstead of hardsubListindices, so any header length renders instead of crashing.[DEBUG-pdf]diagnostics: stats to Logcat on every print; on malformed journals only, a Crashlytics non-fatal plus breadcrumb with the first 120 chars, to confirm which malformed shape reaches the parser. Tagged for easy removal.Replaces #21 (closed by branch rename to match release-branch convention).
Testing
compileDebugKotlin,printVersionInformationprints 3.5.2).