Race condition in ParallelForEachAsync when exceptions are thrown#58
Open
danylofitel wants to merge 2 commits intoDasync:masterfrom
Open
Race condition in ParallelForEachAsync when exceptions are thrown#58danylofitel wants to merge 2 commits intoDasync:masterfrom
danylofitel wants to merge 2 commits intoDasync:masterfrom
Conversation
…se multiple tasks are finishing at the same time they will both read a non-empty list of exceptions. Returning a copy of exception list from ReadExceptions to prevent concurrent reads by CompleteLoopNow and writes by tasks still running in case the loop was canceled.
danylofitel
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not resetting exception list to null in ReadExceptions, so that in case multiple tasks are finishing at the same time they will all read a non-empty list of exceptions.
Returning a copy of exception list from ReadExceptions to prevent concurrent reads by CompleteLoopNow and writes by tasks still running in case the loop was canceled.