Repository navigation
Reconcile reviewed runtime strings and runtime platform A–D - #116
Merged
Merged
Conversation
added 6 commits
October 11, 2026 21:29
Retain exact tested reconciliation tree f79851f. No source deviation.
Dastari
changed the base branch from
feat/runtime-graphql-mutations-20261011
to
main
October 12, 2026 00:06
Dastari
marked this pull request as ready for review
October 12, 2026 00:06
1 of 2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reconcile the reviewed #112 string/binding fix and runtime-platform A–D into one exact-source candidate for final owner review. PostgreSQL prefix/suffix predicates now execute successfully through B's CAS and authority checks and D's repeated GraphQL mutation groups. SQLite empty suffixes match all non-null strings. The combined tests retain backend-emitted bind accounting before protected reads and prove atomic journaling and a single execution per validated response-key group.
The combined source was accepted at
78ad237b7d4d491da595c99eadd8c61e0f00f9db. Owner-authorized merges completed in order #112 → #97 → #113 → #114 → #115 → #116 using the exact tested reconciliation trees. Related PR heads were reconciled onto owner-merged predecessors; all original reviewed commits remain ancestors. Unrelated worktrees remain unchanged. Publication is pending: the protected release workflow remains paused.01d4134da18028ec58e318e0ffd30ab244d0d8e1f2665ce68ed7fdbccb272cb8a783b6379ae5fd8204a1216aff86141ff6500b1dd0bf9adb4b0c64479d4cca34cb04ab0fd27c8313215001591f495c433a59d08be5b663ac952de418eb02dc6321ee08e7Actual merge base: owner-merged D
531fa07117ce5b02a3a126be36d9a0c45e30c0d1; reconciled head:6249f06d4346c71040c1422de6f30cc064f3eb8b; merge:24bfb3cca6c099b6d60dd6fb2913fd9ec2cab83a. This merge has exactly the accepted treef79851ff958a16a64996452d9bc82368ec6af9f4. Published-main baseline remainsdf474c761c4057cb643e27a6582dd0376f56e31f(ORM/macros 0.39.0). Aligned ORM/macros are 0.43.0, unpublished.Required documentation completion followed in #117. Final main is
25355ddc38a04848adcc14d8beef36ef722d49a8, treec6b2b2d3dacbc0fb1af1826b59e1819a84906a19. Differences from the reviewed tree are onlydocs/plans/README.mdand the accepted contract/evidence move fromdocs/plans/active/runtime-platform-capabilities/README.mdtodocs/plans/completed/runtime-platform-capabilities/README.md, with completion metadata/checkpoint updates. Exact Git-tree comparison proves all nine package trees, root manifests/lock, license and release workflow unchanged. Affected documentation and release metadata gates were rerun and passed. A deterministic source-only preview bundle forworkspace-2026.10.12.1is prepared locally, without reserving/tagging/publishing that identity.The integration merges reconcile only conflicting version/changelog/documentation/build metadata. Relative to reviewed D, production runtime code differs only by the reviewed #112 changes in
backend.rs,dialect.rs, andruntime_query.rs. New regression tests exercise their combined behavior. Generated inventory, locks and example version references retain 0.43.0. Every new commit includes[skip ci].Verification
All commands use
CARGO_BUILD_JOBS=2, disk-backed scratch and sequential backend lanes on rustc 1.97.1. SQLite resources are test-owned. PostgreSQL execution provisions disposable PostgreSQL 17 Docker resources with unique ownership metadata and verifies resource identity before cleanup. Ambient application database URLs are rejected. No sibling repository or actual application database is accessed.runexecuted in the owned consumer test, while its standalonemainis compile/run-only and prints instructions.Selected test binaries leave no ignored tests unexecuted. PostgreSQL tests conventionally marked ignored were explicitly enabled with
--include-ignoredor--ignored. Provider-inapplicable tests remain excluded bycfg; full workspace/provider suites and hosted release jobs were not run.Runtime coverage includes static/owned fixed points and legacy source compatibility; required/nullable PostgreSQL DateTime with no default and CurrentTimestamp; host Integer timestamps; legacy unsupported DateTime diagnostics; managed ownership, incoming FK/rebuild rejection, RLS preservation, stale/destructive plans and transactional rollback; CAS concurrency and physical bind budgets; pinned authorization and private projections; atomic journals and caught-cancellation poisoning; confidential AEAD cursor round-trips/tampering/bindings; JSON text/null and exact scalars; alias swaps and filter intent through empty-list lowering; independently authorized committed outputs/deleted preimages; repeated inline/fragment create/update/delete/CAS groups, distinct-alias order and terminal failures.
The new combined cases are
reconciled_prefix_suffix_cas_preserves_unicode_empty_and_bound_valuesandreconciled_string_cas_runs_once_through_graphql_and_atomic_journals.emitted_suffix_bind_budgets_precede_target_reads_for_cas_and_authoritynow runs the formerly gated PostgreSQL success boundaries. All execute on both owned backends. PostgreSQL prefix/suffix CAS and SQLite empty suffixes are successful database execution evidence, rather than rendering-only assertions.Reproduction commands
Public APIs and compiled host examples
No interface deviation from the reviewed contract. A uses
ValidatedRuntimeSchema::physical_schema,with_static_entities, explicitManagedTableSet, read-onlyplan_owned_migration, separate guardedapply_owned_migration, andruntime_mutation_environment. B uses schema-bound create/update/delete requests andMutationContext::mutate_runtimewithin the existing pinned transaction runner; ordinary typed repository journal inserts share that transaction. C/D opt intoruntime-graphqlwithRuntimeGraphqlModule, checked composition, hostRuntimeReadAuthority/RuntimeWriteAuthority, mutation hooks and host-owned cursor protection.External-consumer examples (no direct async-graphql dependency): the SQLite entry points all execute. PostgreSQL journal/GraphQL entry points execute; the string example's PostgreSQL
mainonly prints instructions. Its publicrunfunction executes through the owned PostgreSQL consumer test below.Examples exercise bound prefix/suffix reads, A's owned planning/application and physical certification, B's required-key/CAS/atomic host journal operations, and C/D checked host composition, confidential cursor protection, committed mutations and independent result authorization. Example cursor keys are disposable; production keys and policy/public-revision validation belong to the host.
Compatibility, limitations and owner handoff
Existing static APIs, enum imports/struct literals, repository-only consumers, GraphQL behavior and internal cursor formats are preserved. The string fix requires no data migration. Runtime migrations remain explicit; plans are read-only and unsupported physical semantics fail closed. Use
sqlite,runtime-graphqlorpostgres,runtime-graphqlfor C/D, and the individual backend for framework-neutral A/B. Runtime MSSQL capabilities reject before I/O; live MSSQL execution is not claimed.Approved limitations remain: locked dynamic custom-directive factory registration rejects
unsupported_capabilitybefore schema publication; host extensions/built-ins/checked subscriptions remain available. Hosts provide authenticated cursor encryption with no raw-cursor fallback. Runtime mutations are exact single-record operations, not bulk/nested writes or new upsert semantics. Unsupported modifying incoming cascade actions remain rejected. Legacy epoch-second DateTime defaults stay unsupported while Integer defaults and host-managed integer timestamps retain their semantics. Cancellation poisoning belongs to runtime B; catching an inner static mutation timeout and returningOkstill does not guarantee rollback. Post-commit output denial/error/timeout reports committed/nonretryable status and never implies rollback. Transport or cancellation after commit can leave outcome uncertainty. No durable event replay is claimed.Actions remain paused. Future workflow test coverage is retained, but no workflows were enabled, dispatched or rerun by this work. Hosted checks are not run; local verification is the evidence. No tag or release is created.
For Digibase adoption, review and ordered merges are complete. The owner must still complete the full protected release validation/publication workflow and provide a published immutable workspace tag, resolved full source SHA, aligned ORM/macros versions/features, manifest/checksum and attested exact-source provenance. The release runbook requires that protected workflow; it cannot be dispatched while Actions remain paused. The complete workspace release matrix and workflow attestation have not run. No publication gate is claimed complete. The downstream host then pins that reviewed released identity, verifies its own SQLite/PostgreSQL string gates and A–D integration contracts, supplies its policies/journal/cursor protector, and activates schemas outside the ORM. This unpublished candidate is not an adoption release. Digibase/agql-auth/sibling worktrees remain untouched.
Documentation impact
Explanation: update the runtime mutation/GraphQL references and the approved active plan checkpoint to distinguish the reconciled implementation from owner merge/release; retain string/null semantics, all accepted limitations, changelog/migration/version guidance and exact predecessor identities. Documentation and generated-inventory checks are included in verification.