Repository navigation
Preserve MSRV-compatible atomic router metrics on current Rust - #105
Merged
Merged
Conversation
1 of 2 tasks
Dastari
marked this pull request as ready for review
October 1, 2026 21:10
Dastari
changed the base branch from
fix/orm-release-fixture-locks-20261001
to
main
October 1, 2026 21:28
1 of 2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Rust deprecates AtomicUsize::fetch_update, so warnings-denied router Clippy blocks the source-only workspace release (reproduced in #104 CI router job 110580382026). Replace that private saturating decrement with the equivalent relaxed compare-exchange retry loop. Avoid requiring the replacement try_update API, preserving the declared Rust 1.90 MSRV. Existing tests cover returning gauges to baseline and saturating at zero.
Advance router to 0.5.4 rather than reuse its already-published 0.5.3 package identity. No public API, protocol, configuration, stored data, dependency revision, license policy or binary distribution change. This is a separate compiler compatibility fix; it does not expand the ORM capability PRs.
#104 is merged and this PR targets main. Source-only workspace .3 will include the exact reviewed merge of both follow-ups. .2 remains immutable. No tag or release has been published for .3.
Validation:
cargo test --locked -p graphql-orm-router --lib metrics::tests: two passed, 64 unrelated tests filtered out, none ignored.cargo clippy --locked -p graphql-orm-router --all-targets -- -D warnings: passed on current Rust.RUSTDOCFLAGS="-D warnings" cargo doc --locked -p graphql-orm-router --no-deps: passed.cargo +1.90.0 check --locked -p graphql-orm-router --lib: passed, complete library and dependencies.Documentation impact
Explanation: patch changelog, no-action migration notes, aligned README version and generated inventory.