Skip to content

Verification: explicitly select Git-only packages for semver analysis #100

Open

Description

@Dastari

The local required semver runner can report a pass without analyzing the Git-only ORM package. This is independent of functional PRs #96/#97/#98/#99 and does not require changing package publication/license policy.

Observed with cargo-semver-checks 0.49.0 and the published 82503290c0d0b96b78c687b4e75e5e279439eb59 baseline:

cargo semver-checks --manifest-path crates/graphql-orm/Cargo.toml \
  --baseline-root <owned-baseline>/crates/graphql-orm \
  --default-features --release-type patch

This exits zero immediately with no Building/Parsing/Checking output. scripts/check-semver.sh invokes this shape and then prints 1 changed package lane(s) passed.

Adding explicit package selection actually analyzes the package:

cargo semver-checks -p graphql-orm --manifest-path crates/graphql-orm/Cargo.toml \
  --baseline-root <owned-baseline>/crates/graphql-orm \
  --default-features --release-type patch

At #99 head ae67b01d9222fae5787e02b553e9a24c21e31797 it builds/parses current and baseline, reports 223 passing checks / 30 inapplicable skipped checks, and confirms no semver update required. All scratch/build files use disk-backed directories, not /tmp.

Suggested separate infrastructure fix: explicitly select each package in the local runner, ensure the CI action inputs also select the intended Git-only packages, and require output/evidence that the selected library was analyzed. Preserve publish = false, backend feature separation, macro fixture verification and license policy. Keep intended release-type heuristics separate from the explicit patch-level compatibility checks used by additive feature PRs.

Until corrected, record explicit -p compatibility commands and real analysis results in functional handoffs. Do not equate a runner exit code with completed public-API analysis. Existing backend target-gating failures remain separately tracked in #89.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions