Skip to content
This repository was archived by the owner on Sep 15, 2026. It is now read-only.

Add A3M Router (MCTS-enhanced) to RouterArena #2

Closed
Das-rebel wants to merge 1 commit into from
Closed

Add A3M Router (MCTS-enhanced) to RouterArena #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions router_inference/config/a3m-router-mcts.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
���ky���^�g-�׬r���*'s��^��������m�v��'^�ǥy�b�{ޮȨ�]4���ס��l��Z���zX"������j�׫������l��"��r���+y����残�z��u�lu穱��מ�Ǟ����!rV�u�(�w��(� ^���x���Z�b��^z�zG!j�^z�zO�y�ly�/�d0z����
�^�ױ�h����j/�z�-��v�]��皦��i�Ey�n��ڱ�m����b� "�(�ڮjX�ʊm�h�jب
Comment on lines +1 to +2

@coderabbitai coderabbitai Bot Jun 15, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Verify the actual file contents and encoding

echo "=== File type detection ==="
file router_inference/config/a3m-router-mcts.json

echo -e "\n=== First 500 bytes (hex dump) ==="
xxd -l 500 router_inference/config/a3m-router-mcts.json

echo -e "\n=== Attempting JSON parse ==="
python3 -c "import json; json.load(open('router_inference/config/a3m-router-mcts.json'))" 2>&1 || echo "JSON parse failed"

echo -e "\n=== Raw file contents (head) ==="
head -c 1000 router_inference/config/a3m-router-mcts.json | cat -v

Repository: Das-rebel/RouterArena

Length of output: 1313

🏁 Script executed:

#!/bin/bash

# Check file existence and size
echo "=== File info ==="
ls -lah router_inference/config/a3m-router-mcts.json 2>&1 || echo "File not found"

# Check if it might be gzip or other compressed format
echo -e "\n=== First 10 bytes (decimal) ==="
od -An -td1 -N10 router_inference/config/a3m-router-mcts.json 2>&1 || echo "Cannot read file"

# Look for similar config files
echo -e "\n=== Other config files in directory ==="
find router_inference/config -type f -name "*.json" 2>/dev/null | head -20

# Check if there are any Python files that load this specific config
echo -e "\n=== References to this config file ==="
rg "a3m-router-mcts" --type py 2>/dev/null | head -20

Repository: Das-rebel/RouterArena

Length of output: 950

🏁 Script executed:

#!/bin/bash

# Check base_router.py to understand the JSON structure requirement
echo "=== base_router.py config loading logic (lines 35-84) ==="
sed -n '35,84p' router_inference/router/base_router.py 2>/dev/null || echo "File not found"

Repository: Das-rebel/RouterArena

Length of output: 1779

🏁 Script executed:

#!/bin/bash

# Read a working config file to see expected format
echo "=== Example config (a3m-router.json) ==="
head -50 router_inference/config/a3m-router.json 2>/dev/null

# Try to detect encoding with Python
echo -e "\n=== Attempt to detect file encoding ==="
python3 <<'PYEOF'
import sys

# Try different encodings
file_path = "router_inference/config/a3m-router-mcts.json"
encodings = ['utf-8', 'latin-1', 'cp1252', 'iso-8859-1', 'utf-16', 'utf-16-be', 'utf-16-le']

for enc in encodings:
    try:
        with open(file_path, 'r', encoding=enc) as f:
            content = f.read()
            print(f"✓ {enc}: Success (length: {len(content)})")
            # Try to parse as JSON
            import json
            try:
                json.loads(content)
                print(f"  → Valid JSON!")
            except:
                print(f"  → Not valid JSON")
    except Exception as e:
        print(f"✗ {enc}: {type(e).__name__}")
PYEOF

# Check if this file is actually meant to be committed or if it's generated
echo -e "\n=== Git status of this file ==="
git status router_inference/config/a3m-router-mcts.json 2>/dev/null || echo "Not in git or error"

# Search for references to this config across entire codebase
echo -e "\n=== All references to a3m-router-mcts ==="
rg "a3m.router.mcts|a3m-router-mcts" 2>/dev/null || echo "No references found"

Repository: Das-rebel/RouterArena

Length of output: 814

🏁 Script executed:

#!/bin/bash

# Read the actual content when decoded with latin-1
echo "=== Actual content (latin-1 encoding) ==="
python3 <<'PYEOF'
with open("router_inference/config/a3m-router-mcts.json", "r", encoding="latin-1") as f:
    content = f.read()
    print("First 500 chars:")
    print(repr(content[:500]))
    print("\nFull content:")
    print(content)
PYEOF

# Check if this file appears in git history or is mentioned in docs
echo -e "\n=== Is this file referenced in any docs/README ==="
rg "a3m.*mcts|router.*mcts" --type md --type txt 2>/dev/null | head -20

# List all files that might import or use this config
echo -e "\n=== Files that reference config files ==="
rg "\.json" router_inference --type py | grep -i config | head -20

Repository: Das-rebel/RouterArena

Length of output: 2632

🏁 Script executed:

#!/bin/bash

# Check if there's a pattern - are there multiple a3m-* routers and is mcts a variant?
echo "=== a3m-* config files ==="
ls -la router_inference/config/a3m* 2>/dev/null

# Check git log for when this file was added and if it was always corrupted
echo -e "\n=== Git history of this file ==="
git log --oneline -- router_inference/config/a3m-router-mcts.json 2>/dev/null | head -10

# Check if there are any tests that might use this router
echo -e "\n=== Test files that might reference routers ==="
find . -name "*test*.py" -type f 2>/dev/null | head -10

# Search tests for any router usage
echo -e "\n=== Router references in test files ==="
rg "router_name|a3m" --type py -g '*test*' 2>/dev/null | head -20

Repository: Das-rebel/RouterArena

Length of output: 442

File content is corrupted — router initialization will fail with UnicodeDecodeError.

The file contains binary/corrupted data and cannot be decoded as UTF-8. When BaseRouter._load_config() attempts to open this file with encoding="utf-8", it will raise a UnicodeDecodeError at byte position 0, preventing router instantiation.

The file currently has no references in the codebase, but will fail immediately if instantiated with router_name="a3m-router-mcts". For reference, a properly formatted config should be valid JSON matching the structure in a3m-router.json:

{"pipeline_params":{"router_name":"a3m-router-mcts","router_cls_name":"...","models":[...]}}

Fix by regenerating or restoring the original file with correct UTF-8 encoding and valid JSON content matching the expected structure per base_router.py lines 68-84.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@router_inference/config/a3m-router-mcts.json` around lines 1 - 2, The
a3m-router-mcts.json file contains corrupted binary data that cannot be decoded
as UTF-8, causing BaseRouter._load_config() to fail with a UnicodeDecodeError
when attempting to load the router configuration. Regenerate or restore the file
with correct UTF-8 encoding and valid JSON content. The JSON must match the
expected configuration structure with a root "pipeline_params" object containing
router_name set to "a3m-router-mcts", a router_cls_name field, and a models
array, following the same format as a properly configured router configuration
file.

Expand Down
Binary file added router_inference/predictions/a3m-router-mcts-robustness.json
View file
Open in desktop
Binary file not shown.
Binary file added router_inference/predictions/a3m-router-mcts.json
View file
Open in desktop
Binary file not shown.