Repository navigation
Fix: Ignore tailcat_binary and keep the agent migration to tunnel accounts - #104
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Colab account declared before 3.0 with tailcat_binary = "tailcat-disabled-for-this-account" was refused whole by 3.0.2, with a message telling a Colab user to set up a tunnel agent. Both are wrong: that field carries no connection intent, and the agent migration applies to the tunnel kind only.
Spec change first, in docs/SPEC.md Connection strategies and Agent and pairing item 14.
Behaviour after this change, in Provider.init:
No other removed field exists in the code: a grep for auto_install and QUIC account options found none.
Red then green: tests/test_tailcat_removed.py had 17 failures before the code change (per-kind messages, one notice per alias for all five kinds) and 30 passes after. Full suite: 2286 passed, 7 skipped. ruff check letify tests is clean. Guides and READMEs in English and Korean updated.