Repository navigation
Feat: add RSX attributes for MatchParentSize, WindowDrag, PressFeedback (FR-10) - #176
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #166
Adds RSX attributes and widget component props for the three
compose-rust0.0.6 modifiers (MatchParentSize,WindowDrag, andPressFeedback) and removes them fromMODIFIERS_WITHOUT_AN_RSX_ATTRIBUTEinrsx_surface.rs.Changes
docs/SPEC.md: documentsmatch_parent_size,window_drag, andpress_feedbackunderFR-10.dioxus-compose/src/lib.rsanddioxus-compose/src/renderer.rs: addsmatch_parent_size(slot 22),window_drag(slot 23, preserving bothtrueandfalse), andpress_feedback(slot 24, accepting(f32, f32)orModifier::PressFeedback).dioxus-compose/src/widgets.rs: forwardsmatch_parent_size,window_drag, andpress_feedbackon widget components.dioxus-compose/tests/rsx_surface.rsanddioxus-compose/tests/modifier_attributes.rs: verifies every schema modifier is reachable and tests wire mutations for slots 22, 23, and 24.