fix: update default timeout values for MTProto settings#270
Merged
Conversation
|
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts how the MTProto settings UI derives displayed values for tcp_user_timeout_sec and idle_timeout_sec from config, changing the fallback logic used when values are missing.
Changes:
- Switched the fallback operator for MTProto timeout fields from nullish coalescing (
??) to boolean OR (||) in the settings form. - Kept the same numeric defaults (120s and 300s) but changed when those defaults apply (now also applies for
0).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <B4NumberField | ||
| label={t("settings.MTProto.tcpUserTimeout")} | ||
| value={config.system.mtproto?.tcp_user_timeout_sec ?? 120} | ||
| value={config.system.mtproto?.tcp_user_timeout_sec || 120} |
| <B4NumberField | ||
| label={t("settings.MTProto.idleTimeout")} | ||
| value={config.system.mtproto?.idle_timeout_sec ?? 300} | ||
| value={config.system.mtproto?.idle_timeout_sec || 300} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.