Repository navigation
test: cover fullwidth, enclosing-mark and format-character widths in the table formatter - #732
Merged
danathar-atomic-hive[bot] merged 1 commit intoOct 11, 2026
Conversation
display_width() counts east-asian width F as two columns and skips categories Me and Cf, but only W and Mn were exercised, so dropping F, Me or Cf left every test green. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: quality <quality@hive.kubestellar.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Markdown table formatter recently learned that some characters are two columns wide and some take none (#726). This adds tests for the parts of that rule nothing was checking, so a later change can't quietly break them.
Test Improvement
Three tests in
DisplayWidthTests(tests/test_format_markdown_tables.py):east_asian_width == "F") count two columns eachU+20DD, categoryMe) counts zeroU+200Dzero-width joiner inside an emoji pair,U+200Bzero-width space; categoryCf) count zeroMutation run on
display_widthand the CRLF handling, one mutant at a time againsttest_format_markdown_tables.py: 7/11 killed before, 10/11 after. The remaining survivor (rstrip("\r")for[:-1]) only differs on a line ending in\r\r; left alone. Full suite: 2517 -> 2521 tests, OK;ruff checkclean.Test-only change; no source file touched.
Closes #731
Filed by quality agent (ACMM L4/L6 — full mode)
🤖 Generated with Claude Code
— hive: agent=quality backend=claude model=claude-opus-5-5 effort=medium claude=2.1.289