Skip to content

fix outdated info of README #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dixudx wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix outdated info of README #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,8 @@ curl -L https://raw.github.com/DamnWidget/VenGO/master/install.sh | bash
Finally the command below will enable the `vengo` command in your system

```
$ source $HOME/.VenGO/bin/vengo
$ source $HOME/.VenGO/bin/vengo.sh
$ source $HOME/.VenGO/bin/includes/*
Copy link
Owner

@DamnWidget DamnWidget Jul 14, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will add this as a troubleshooting section as it is not needed to explicitly include the includes directory as they are implicitly included by vengo.sh. For example I never had to do it in any of my Linux boxes or my OS X (I am using Gentoo and Manjaro with zsh by the way).

I tested it with bash as well as csh, zsh and ash and even there are scripts for fish, that the function is not defined in your system when you run vengo_activate is a problem of your SHELL/environment so I will add this as a workaround in case that the user encounters this problem.

```

#### 3 Optional
Expand All @@ -64,7 +65,8 @@ If you want to enable `vengo` in permanent basis in your system, you can add it
files like

```
echo "source $HOME/.VenGO/bin/vengo" >> $HOME/.bashrc
$ echo "source $HOME/.VenGO/bin/vengo" >> $HOME/.bashrc
$ echo "source $HOME/.VenGO/bin/includes/*" >> $HOME/.bashrc
Copy link
Owner

@DamnWidget DamnWidget Jul 14, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

```

#### Fish users
Expand Down Expand Up @@ -112,11 +114,11 @@ $ vengo mkenv -g go1.2.2 MyEnv

This will create a new isolated environment that uses go1.2.2 and uses `$VENGO_HOME/MyEnv` as `GOPATH`

To activate this new environment thw programmer just have to use `vengo activate` with the name of the recently created
To activate this new environment thw programmer just have to use `vengo_activate` with the name of the recently created
environment

```
$ vengo activate MyEnv
$ vengo_activate MyEnv
```
Copy link
Owner

@DamnWidget DamnWidget Jul 14, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was pretty sure that I updated this but seems like I didn't. Thanks.


Now, whatever is installed using `go get` will be installed in the new isolated virtual go environment. It's `GOPATH` bin
Expand Down
2 changes: 1 addition & 1 deletion bin/includes/env
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ function check_environment_exixtance {
environment="$1"
if [ ! -d "$VENGO_HOME/$environment" ]; then
echo "VenGO: Environment '$environment' doesn't exists." >&2
suggest "try to create it with 'vengo create $environment -g <go_version>'" >&2
suggest "try to create it with 'vengo mkenv -g <go_version> $environment'" >&2
return 1
fi
return 0
Expand Down