Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submitting this as a draft PR since there are probably a lot of changes within it you don't want to pick up, so best not to merge it directly and instead pick out what you like.
I made a CLI converter target so that I could easily time the conversion speed and see if there were any easy optimizations.
There were a few on the onnxruntime side, for RTNeural I'd have to take a closer look.
If you have a "known good" audio file and corresponding MIDI output, along with what parameters you use to convert the file, I could use it as a ground truth while attempting more aggressive optimizations.. maybe Jatin would have some ideas if it were possible to bump to RTNeural v2!