You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This addresses Issue #451, where piping reads to hisat2 aligner via stdin does not work. Please let me know if you have any questions, or if there are any checks you'd like me to perform regarding this!
Thanks for the reminder. I have examined the code. There are two issues:
There is a step in checking the read lengths in the wrapper (https://github.com/DaehwanKimLab/hisat2/blob/master/hisat2#L294-L318), which needs to use about 10,000 reads to generate length distributions and generate the option "--read-lengths" using the hisat2_read_statistics.py script. With the pipe input, the current implementation will cause this step fail so it won't generate the--read-lengths option. I think this is related to how HISAT2 handles some repeat regions based on the code. If we allow piping, then about 10,000 will be missed in the alignment as they are piped in this python script. So I guess your pipeline needs to run the python script explicitly and feeds the result to to the --read-lengths option to have a consistent result when using read file as input.
Another minor issue is that the piping should only work for single-end data, so may be the check is still necessary for mate1s and mate2s options.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi HISAT2 team,
This addresses Issue #451, where piping reads to hisat2 aligner via stdin does not work. Please let me know if you have any questions, or if there are any checks you'd like me to perform regarding this!
Thanks,
John