Repository navigation
docs: README in the same form as the other hackathon builds, working notes out of the repository - #1
Merged
Merged
Conversation
The hackathon is over: Metaphor was a finalist on the ADI Foundation bounty at ETHDenver 2026. The repository becomes the public record of the build, so what only served the team during the event leaves it for the team's own notes. - kept and moved to docs/: SPEC.md, BOUNTY_COMPLIANCE.md and DEMO_GUIDE.md - SPEC.md: the internal audit summary removed, the Daml SDK is 3.4.11 as in daml.yaml, the AI engine has 21 tests, and the open items become the limits at submission (no more "no demo video") - BOUNTY_COMPLIANCE.md carries the project's final name instead of Outward, and links the addresses in the README; DEMO_GUIDE.md points at SPEC.md for the Hedera address note - removed, kept as notes outside the repository: CLAUDE.md, TIMELINE.md, PROJECT_OVERVIEW.md, DEPLOY.md, DEPLOYED_CONTRACTS.md, Explication.md, AUDIT.md, devC.md, A-FAIRE-DANS-FRONT.md - removed: the root copies of the landing images, the logo and the sponsor logos (the app serves its own copies from packages/frontend/public), a local Claude Code skill, a Yarn install state in a pnpm workspace, and the create-next-app README of the frontend - .gitignore: .claude/ and .yarn/ ignored, the devA.md entry gone with the notes Claude-Session: https://claude.ai/code/session_012G1hYLp2Jgaqw3X37XaM1j
…MIT licence - hero: one-line pitch, badges, the result (finalist, ADI Foundation, Open Project Submission, $300, ETHDenver 2026) and a paragraph on the event; table of contents, License section and footer - how it works, the four layers, the architecture, and what is live vs. simulated at submission (Canton on a local sandbox, 0G with a mock fallback, demo data behind the aggregated API) - deployed contracts on ADI Chain testnet, Sepolia and Hedera Testnet, all twelve checked on chain on 16 September 2026; the clone URL points at DVB-ANS/Metaphor, no longer ETH-DENVER - tests: 111 Forge (ADI), 74 Forge (Hedera), 28 Daml Script, 21 Vitest; the Forge and Vitest suites re-run green on 16 September 2026 - team named with roles instead of Dev A, B and C; MIT licence for the three authors, the vendored Hedera interfaces keep their Apache-2.0 headers Claude-Session: https://claude.ai/code/session_012G1hYLp2Jgaqw3X37XaM1j
There was a problem hiding this comment.
🟡 Changes recommended
Six moderate documentation issues remain unresolved.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
This documentation-only PR turns Metaphor’s repository into a public hackathon record, consolidating documentation, removing internal artifacts, and adding licensing.
Changes:
- Rewrites the README with architecture, deployment, setup, testing, and team details.
- Consolidates public documents under
docs/. - Removes working notes, scaffold files, unused assets, and local tooling; adds MIT licensing and ignore rules.
Review findings:
README.md:152— Moderate (3 votes): Reconcile the Canton Devnet deployment status withdocs/BOUNTY_COMPLIANCE.md.README.md:174— Moderate (3 votes): Document running the backend in the background or a second terminal.README.md:31— Moderate (1 vote): Clarify the $25,000 bounty versus the $300 finalist award.README.md:149— Moderate (1 vote): Reconcile the documented five bonds with the two actually registered.README.md:189— Moderate (1 vote): Build the Hedera package before invoking deployment.docs/SPEC.md:188— Moderate (1 vote): Update the demo guide to usedpm testorpnpm test:canton.
File summaries
| File | Reviewed change |
|---|---|
README.md |
Rewritten public overview and setup guide |
packages/frontend/README.md |
Removed scaffold README |
markdown/TIMELINE.md |
Removed internal roadmap |
markdown/PROJECT_OVERVIEW.md |
Removed internal overview |
markdown/Explication.md |
Removed internal technical notes |
markdown/devC.md |
Removed progress notes |
markdown/DEPLOYED_CONTRACTS.md |
Removed; deployment details consolidated into README |
markdown/DEPLOY.md |
Removed obsolete deployment guide |
markdown/CLAUDE.md |
Removed internal Claude context |
markdown/AUDIT.md |
Removed internal audit |
markdown/A-FAIRE-DANS-FRONT.md |
Removed private task list |
logo bandeau/Canton Network.svg |
Removed unused sponsor asset |
logo bandeau/ADI Foundation.svg |
Removed unused sponsor asset |
logo bandeau/0G Labs.svg |
Removed unused sponsor asset |
LICENSE |
Added MIT license |
docs/SPEC.md |
Updated toolchain, tests, and submission details |
docs/DEMO_GUIDE.md |
Updated demo documentation |
docs/BOUNTY_COMPLIANCE.md |
Updated bounty compliance documentation |
.gitignore |
Added local tooling exclusions |
.claude/skills/audit/SKILL.md |
Removed local audit skill |
Review details
Suppressed comments (4)
README.md:31
- This says the project was a finalist on a $25,000 bounty, while the new result line above and the PR description identify the finalist award as $300. Please clarify the total bounty versus the award, or use one consistent amount so the public result is not contradictory.
> a finalist on ADI Foundation's $25,000 Open Project Submission bounty.
README.md:151
- The README now claims five registered bonds, but the checked-in
register-bond.tsregisters exactly two and the demo guide's on-chain verification expectsbondCount() == 2. Readers cannot reproduce this documented state; reconcile the count with the verified on-chain result and update the related procedure/documentation together.
- **On chain:** the ADI contracts on ADI Chain testnet and Sepolia, and `CouponScheduler` and
`YieldDistributor` on Hedera Testnet, where `CouponScheduler` holds five registered bonds with their
coupon dates computed on chain.
README.md:190
- On a fresh checkout,
pnpm installdoes not create the Forge output thatpackages/contracts-hedera/src/deploy.tsreads (out/CouponScheduler.sol/CouponScheduler.jsonandout/YieldDistributor.sol/YieldDistributor.json), so this documented deploy command fails before deployment. Build the Hedera package before invokingdeploy.
# Hedera Testnet, with HEDERA_OPERATOR_ID and HEDERA_OPERATOR_KEY
pnpm --filter contracts-hedera run deploy
docs/SPEC.md:188
- This updates the Canton toolchain to Daml SDK 3.4.11 via DPM, but
docs/DEMO_GUIDE.mdstill instructs users to runcd packages/contracts-canton && daml test; the package script and Canton README usedpm test. On a DPM-only setup the documented demo test command is unavailable, so update that guide to usedpm testorpnpm test:canton.
- Files reviewed: 16/29 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+152
to
+153
| - **Canton:** the Daml contracts pass 28 Daml Script tests and run on a local sandbox. The deployment | ||
| on Canton's Devnet L1 asked for by the bounty was not done. |
Comment on lines
+174
to
+175
| pnpm dev:backend # Express API on http://localhost:3001 | ||
| pnpm dev:frontend # Next.js on http://localhost:3000 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Metaphor was a finalist on the ADI Foundation bounty (Open Project Submission, $300) at ETHDenver 2026. This turns the repository into the public record of the build, in the same form as the team's other hackathon repositories.
README
DVB-ANS/Metaphor, no longerETH-DENVER)Repository
markdown/becomesdocs/with the three public documents (SPEC, bounty compliance, demo guide), correctedpackages/frontend/public), plus a local Claude Code skill, a Yarn install state and the create-next-app READMENo code change.
https://claude.ai/code/session_012G1hYLp2Jgaqw3X37XaM1j