Repository navigation
feat: full LBL analysis in EventRates CI validations - #135
Merged
Merged
Conversation
|
This is your first PR, thank you for contributing to MaCh3 DUNE! |
Charlotte-Knight
marked this pull request as ready for review
September 3, 2026 10:06
henry-wallace-phys
approved these changes
Oct 8, 2026
henry-wallace-phys
left a comment
Contributor
There was a problem hiding this comment.
This all seems sensible to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the CI validations to introduce full fits, starting with the LBL analysis.
I added a step to the CI validations to mount cvmfs, and then used the files we stored there to run EventRates. This gets compared to a previous run of EventRates in the same way that the current limited EventRates CI works. I run with 10% downsampling so the workflow completes in a reasonable time.
I also took the opportunity to refactor and standardise how we build the Docker images.
We should prioritise getting the Atmospherics integrated as well, though I'd prefer making an issue for this and solving it in another PR since I'll have less time next week to continue with this.
I also think that the validations could be done better in a few different ways (also future work):