Skip to content

feat: full LBL analysis in EventRates CI validations - #135

Merged
henry-wallace-phys merged 34 commits into
developfrom
charlotte-knight/ci-improvements
Oct 9, 2026
Merged

henry-wallace-phys merged 34 commits into
developfrom
charlotte-knight/ci-improvements

Conversation

@Charlotte-Knight

@Charlotte-Knight Charlotte-Knight commented Aug 25, 2026 •

Copy link
Copy Markdown
Member

Update the CI validations to introduce full fits, starting with the LBL analysis.

I added a step to the CI validations to mount cvmfs, and then used the files we stored there to run EventRates. This gets compared to a previous run of EventRates in the same way that the current limited EventRates CI works. I run with 10% downsampling so the workflow completes in a reasonable time.

I also took the opportunity to refactor and standardise how we build the Docker images.

We should prioritise getting the Atmospherics integrated as well, though I'd prefer making an issue for this and solving it in another PR since I'll have less time next week to continue with this.

I also think that the validations could be done better in a few different ways (also future work):

  1. The downsampling is configured with a sed command which is awful but I think the best way to do it currently. The alternative is keeping a copy of the Beam sample configs that only have the downsampling as a difference. Or we could introduce downsampling as a cli option for the EventRates app, which is my preference, but requires more work.
  2. The CI validations could be integrated into an app like they are in MaCh3 core. If this was done then we could run the validations locally before pushing.

@github-actions

Copy link
Copy Markdown

This is your first PR, thank you for contributing to MaCh3 DUNE!

@Charlotte-Knight Charlotte-Knight changed the title unified pr workflow feat: full LBL analysis in EventRates CI validations Aug 28, 2026
@Charlotte-Knight
Charlotte-Knight marked this pull request as ready for review September 3, 2026 10:06

@henry-wallace-phys henry-wallace-phys left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all seems sensible to me

@henry-wallace-phys
henry-wallace-phys merged commit 763dd5f into develop Oct 9, 2026
7 checks passed
@henry-wallace-phys
henry-wallace-phys deleted the charlotte-knight/ci-improvements branch October 9, 2026 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants