Conversation
Collaborator
|
Thanks! I see this PR is similar to #2 but somehow that didn't get merged. I'll also test this on the Windows side. |
Author
|
Yes... that was a PR that Morten rejected... he made some comments about
the if statement. I forget the details and I think I just forgot to make
the change. If you want to incorporate the comments morten made, I can do
that... just tell me...
…On 6 April 2018 at 09:55, David Verelst ***@***.***> wrote:
Thanks! I see this PR is similar to #2
<#2> but somehow
that didn't get merged. I'll also test this on the Windows side.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#4 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AJJ-Pz7CU8W5KUEiTR_FMP5MyzrhTk6bks5tlx9qgaJpZM4TIpSX>
.
|
This was referenced Nov 7, 2018
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These were the changes that I needed to make to the code to get it to run in Linux