Skip to content

fix(backend): guard startMcp and use direct url in mastra store #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JOY (JOY) merged 1 commit into from
Aug 26, 2026
Merged

fix(backend): guard startMcp and use direct url in mastra store #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion apps/backend/src/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,11 @@ async function start() {
},
});

await startMcp(app);
try {
await startMcp(app);
} catch (e) {
Logger.error('Failed to initialize Mastra MCP server:', e);
}

app.useGlobalPipes(
new ValidationPipe({
Expand Down
2 changes: 1 addition & 1 deletion libraries/nestjs-libraries/src/chat/mastra.store.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@ import { PostgresStore } from '@mastra/pg';

export const pStore = new PostgresStore({
id: 'postiz-store',
connectionString: process.env.DATABASE_URL!,
connectionString: process.env.DATABASE_DIRECT_URL || process.env.DATABASE_URL!,

@gemini-code-assist gemini-code-assist Bot Aug 26, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using the non-null assertion operator ! on process.env.DATABASE_URL is unsafe because if both DATABASE_DIRECT_URL and DATABASE_URL are missing, it will pass undefined to PostgresStore, leading to a runtime crash with a cryptic error. It is safer to validate that at least one of these environment variables is defined and throw a clear configuration error if they are missing.

  connectionString: (() => {
    const url = process.env.DATABASE_DIRECT_URL || process.env.DATABASE_URL;
    if (!url) {
      throw new Error('Database connection URL is missing. Please set DATABASE_DIRECT_URL or DATABASE_URL.');
    }
    return url;
  })(),

});
Loading