fix(oidc): portal-origin logins provision customer-type users #19
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,7 +20,7 @@ func TestOIDCLoginAutoCreatesSystemUser(t *testing.T) { | |
| Name: "Ada Lovelace", | ||
| Picture: "https://example.com/ada.png", | ||
| RawProfile: `{"sub":"sub-123"}`, | ||
| }, config.AuthConfig{TokenTTLHours: 2}, "127.0.0.1", "go-test", false) | ||
| if err != nil { | ||
| t.Fatalf("loginWithOIDCProfile() error = %v", err) | ||
| } | ||
|
|
@@ -78,7 +78,7 @@ func TestOIDCLoginReusesExistingIdentity(t *testing.T) { | |
| Name: "Updated Name", | ||
| Picture: "https://example.com/updated.png", | ||
| RawProfile: `{"sub":"sub-123"}`, | ||
| }, config.AuthConfig{TokenTTLHours: 2}, "127.0.0.1", "go-test", false) | ||
| if err != nil { | ||
| t.Fatalf("loginWithOIDCProfile() error = %v", err) | ||
| } | ||
|
|
@@ -133,7 +133,7 @@ func TestOIDCLoginSyncsOrganizationsAndTeams(t *testing.T) { | |
| RawProfile: `{"sub":"7a3562bb-f529-45e0-bdfa-b73ca55ce8c8"}`, | ||
| } | ||
|
|
||
| ret, err := svc.loginWithOIDCProfile(profile, config.AuthConfig{TokenTTLHours: 2}, "127.0.0.1", "go-test", false) | ||
| if err != nil { | ||
| t.Fatalf("loginWithOIDCProfile() error = %v", err) | ||
| } | ||
|
|
@@ -176,3 +176,116 @@ func TestOIDCLoginSyncsOrganizationsAndTeams(t *testing.T) { | |
| t.Fatalf("expected priority level 10 for LEAD, got %d", agentProfile.PriorityLevel) | ||
| } | ||
| } | ||
|
|
||
| // A first-time OIDC login from the support portal must provision a | ||
| // customer-type user with no staff role, no agent profile, and no | ||
| // organization/team provisioning: the dashboard middleware rejects | ||
| // non-employee users, so the portal door cannot open the staff surface. | ||
| func TestOIDCLoginPortalOriginCreatesCustomerUserWithoutStaffProvisioning(t *testing.T) { | ||
| db := setupAuthServiceTestDB(t) | ||
| svc := newOIDCLoginService() | ||
|
|
||
| ret, err := svc.loginWithOIDCProfile(&oidcLoginProfile{ | ||
| Subject: "customer-sub-1", | ||
| Email: "customer@example.com", | ||
| PreferredUsername: "portalcustomer", | ||
| Name: "Portal Customer", | ||
| RawProfile: `{"sub":"customer-sub-1"}`, | ||
| }, config.AuthConfig{TokenTTLHours: 2}, "127.0.0.1", "go-test", true) | ||
| if err != nil { | ||
| t.Fatalf("loginWithOIDCProfile() error = %v", err) | ||
| } | ||
| if ret == nil || !strings.HasPrefix(ret.AccessToken, "ak_") { | ||
| t.Fatalf("expected ak_ access token, got %+v", ret) | ||
| } | ||
|
|
||
| var user models.User | ||
| if err := db.Take(&user, "username = ?", "portalcustomer").Error; err != nil { | ||
| t.Fatalf("expected portal customer user to be created: %v", err) | ||
| } | ||
| if user.UserType != enums.UserTypeUser { | ||
| t.Fatalf("portal-origin user type = %q, want customer (%q)", user.UserType, enums.UserTypeUser) | ||
| } | ||
|
|
||
| var roleCount int64 | ||
| if err := db.Model(&models.UserRole{}).Where("user_id = ?", user.ID).Count(&roleCount).Error; err != nil { | ||
| t.Fatalf("count user roles: %v", err) | ||
| } | ||
| if roleCount != 0 { | ||
| t.Fatalf("portal-origin user must not receive staff roles, got %d", roleCount) | ||
| } | ||
|
|
||
| var orgCount int64 | ||
| if err := db.Model(&models.Organization{}).Count(&orgCount).Error; err != nil { | ||
| t.Fatalf("count organizations: %v", err) | ||
| } | ||
| if orgCount != 0 { | ||
| t.Fatalf("portal-origin login must not provision organizations, got %d", orgCount) | ||
| } | ||
|
|
||
| var profileCount int64 | ||
| if err := db.Model(&models.AgentProfile{}).Where("user_id = ?", user.ID).Count(&profileCount).Error; err != nil { | ||
| t.Fatalf("count agent profiles: %v", err) | ||
| } | ||
| if profileCount != 0 { | ||
| t.Fatalf("portal-origin user must not receive an agent profile, got %d", profileCount) | ||
| } | ||
| } | ||
|
|
||
| // Even an allowlisted break-glass admin must stay a role-less customer when | ||
| // entering through the support portal: the allowlist elevates on the staff | ||
| // surface only. | ||
| func TestOIDCLoginPortalOriginIgnoresBreakGlassAllowlist(t *testing.T) { | ||
| db := setupAuthServiceTestDB(t) | ||
| svc := newOIDCLoginService() | ||
|
|
||
| ret, err := svc.loginWithOIDCProfile(&oidcLoginProfile{ | ||
| Subject: "admin-sub-1", | ||
| Email: "joy@dos.ai", | ||
| PreferredUsername: "joy", | ||
| Name: "Joy", | ||
| RawProfile: `{"sub":"admin-sub-1"}`, | ||
| }, config.AuthConfig{TokenTTLHours: 2, BreakGlassEmails: "joy@dos.ai"}, "127.0.0.1", "go-test", true) | ||
| if err != nil { | ||
| t.Fatalf("loginWithOIDCProfile() error = %v", err) | ||
| } | ||
| if ret == nil { | ||
| t.Fatalf("expected non-nil login response") | ||
| } | ||
|
|
||
| var user models.User | ||
| if err := db.Take(&user, "username = ?", "joy").Error; err != nil { | ||
| t.Fatalf("expected portal user to be created: %v", err) | ||
| } | ||
| if user.UserType != enums.UserTypeUser { | ||
| t.Fatalf("portal-origin admin email user type = %q, want customer", user.UserType) | ||
| } | ||
|
|
||
| var roleCount int64 | ||
| if err := db.Model(&models.UserRole{}).Where("user_id = ?", user.ID).Count(&roleCount).Error; err != nil { | ||
| t.Fatalf("count user roles: %v", err) | ||
| } | ||
| if roleCount != 0 { | ||
| t.Fatalf("break-glass allowlist must not elevate on the portal surface, got %d roles", roleCount) | ||
| } | ||
| } | ||
|
|
||
| func TestIsSupportPortalNext(t *testing.T) { | ||
| cases := []struct { | ||
| next string | ||
| expected bool | ||
| }{ | ||
| {next: "/support/community", expected: true}, | ||
| {next: "/support", expected: true}, | ||
| {next: " /support/tickets ", expected: true}, | ||
| {next: "/dashboard", expected: false}, | ||
| {next: "", expected: false}, | ||
| {next: "/supportevil", expected: false}, | ||
|
Comment on lines
+278
to
+283
There was a problem hiding this comment. Add test cases to verify that {next: "/support/community", expected: true},
{next: "/support", expected: true},
{next: " /support/tickets ", expected: true},
{next: "/support?ticket=123", expected: true},
{next: "/support/tickets?resolved=true#anchor", expected: true},
{next: "/dashboard", expected: false},
{next: "", expected: false},
{next: "/supportevil", expected: false}, |
||
| } | ||
|
|
||
| for _, tc := range cases { | ||
| if got := isSupportPortalNext(tc.next); got != tc.expected { | ||
| t.Fatalf("isSupportPortalNext(%q) = %v, want %v", tc.next, got, tc.expected) | ||
| } | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current implementation of
isSupportPortalNextdoes not handle query parameters or URL fragments (e.g.,/support?ticket=123or/support/tickets?resolved=true#anchor). If a customer logs in via the support portal with any query parameters or fragments in the redirect path,isSupportPortalNextwill returnfalse. This causes them to be incorrectly provisioned as an employee (UserTypeEmployee) and receive default staff roles, which is a critical security vulnerability (privilege escalation).We should strip query parameters and fragments before performing the prefix and equality checks.