Conversation
The web image rewrites /api/v2/* to the calcom-api service, but that service was never deployed, so every Platform API v2 call against cal.crove.com failed. Publishes ghcr.io/dos/crove-cal-api from apps/api/v2/Dockerfile. Build args for prisma generate are format-valid placeholders rather than production credentials, because generate only parses the schema and real build args would be baked into image layers.
… compile nest build failed with six TS4094 errors inside packages/prisma/generated/prisma/internal/prismaNamespace.ts because declaration emit cannot represent the #private marker Prisma generates. apps/api/v2 is an application whose entrypoint is dist/apps/api/v2/src/main.js, and nothing in the repo imports @calcom/api-v2, so the emitted .d.ts files were never consumed.
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_850a1332-3819-4c61-8699-65c2882e971b) |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughAPI v2 no longer emits TypeScript declaration files. A new GitHub Actions workflow builds and pushes the API v2 Docker image to GHCR on selected branch changes or manual dispatch. ChangesAPI v2 delivery
Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Feature Sequence Diagram(s)sequenceDiagram
participant GitHubActions
participant DockerBuildx
participant GHCR
GitHubActions->>DockerBuildx: Build API v2 Docker image
DockerBuildx->>GHCR: Push latest and commit SHA tags
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Some tools did not complete. Review the errors below. 🔧 Biome (2.5.10)apps/api/v2/tsconfig.jsonBiome could not lint this file: configuration resulted in errors. Check the repository's Biome configuration and plugins. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Adds a workflow that builds apps/api/v2/Dockerfile and publishes ghcr.io/dos/crove-cal-api, so the Platform API v2 can be deployed as its own service - the web image rewrites /api/v2/* to a calcom-api service that did not exist until now. Also fixes the build itself: nest build failed with six TS4094 errors inside packages/prisma/generated/prisma/internal/prismaNamespace.ts because declaration emit cannot represent the #private marker Prisma generates. apps/api/v2 is an application whose entrypoint is dist/apps/api/v2/src/main.js and nothing in the repo imports @calcom/api-v2, so declaration output was never consumed. Build args for prisma generate are format-valid placeholders rather than production credentials, since generate only parses the schema and real values would be baked into image layers. Note: the image builds and publishes, but running it still needs a packaging fix - packages/prisma declares main: index.ts with no compiled output, which plain node cannot load.
Note
Low Risk
Changes are limited to CI packaging and TypeScript build output; database URLs in the workflow are placeholders and runtime config is unchanged by this diff.
Overview
Adds GitHub Actions to build
apps/api/v2/Dockerfileand pushghcr.io/dos/crove-cal-api(latestand commit SHA) on pushes todev/mainwhen API v2, shared packages, or the workflow change, with manualworkflow_dispatchsupport.The workflow uses Buildx, GHCR login via
GITHUB_TOKEN, GHA layer cache scoped toapi-v2, andcache-tomode=minso a build stage that setsDATABASE_URLinENVis not fully cached.DATABASE_URL/DATABASE_DIRECT_URLbuild-args are dummy connection strings forprisma generateonly, avoiding real secrets in image layers.apps/api/v2/tsconfig.jsonsetsdeclaration: falsesonest buildno longer emits.d.tsand fails on Prisma’s#privatetypes (TS4094); API v2 is not consumed as a published typings package.Reviewed by Cursor Bugbot for commit 6752eeb. Configure here.
Summary by CodeRabbit
Chores
Refactor