fix create_datastore_script function#147
Merged
Merged
Conversation
…n; some text formatting improvements
…om DESCRIPTION file
…RIPTION file and adding them to the Script reference.
wright13
reviewed
Jan 23, 2026
| #check status code; suggest logging in to VPN if errors occur: | ||
| status_code <- httr::stop_for_status(contacts_req)$status_code | ||
| if (!status_code == 200) { | ||
| stop("ERROR: DataStore connection failed. Are you logged in to the VPN?\n") |
Collaborator
There was a problem hiding this comment.
Possibly worth changing the wording of these error messages, as a non-200 status could be a lot of things besides failed connection. It'll be a moot point whenever we refactor to use NPSdatastore though, so I'm also ok with leaving it as-is for now.
wright13
approved these changes
Jan 23, 2026
Collaborator
wright13
left a comment
wright13
left a comment
There was a problem hiding this comment.
See comment on error message phrasing, otherwise looks good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #146
Updated create_datastore_script function to play well with DataStore v8 API; also improved formatting of text printed to the screen and made the DataStore reference link printed to the screen clickable.
This PR also closes #148
It allows the user to set the for_or_by_NPS flag (default = TRUE)
this PR now also partially addresses #143