feat(): Use function overloads for std::optional API

docs/mpmc/priority_queue.md

@@ -30,7 +30,7 @@ if (read_success) {
 
 There is also a `std::optional` API for `Pop`:
 ```c
-auto read = queue_events.PopOptional();
+auto read = queue_events.Pop();
 
 if (read) {
     actor2.ProcessEvent(read);

docs/mpmc/queue.md

@@ -30,7 +30,7 @@ if (read_success) {
 
 There is also a `std::optional` API for the `Pop` method:
 ```c
-auto job = queue_jobs.PopOptional();
+auto job = queue_jobs.Pop();
 
 if (job) {
     worker.ProcessJob(read);

docs/spsc/priority_queue.md

@@ -30,7 +30,7 @@ if (read_success) {
 
 There is also a `std::optional` API for `Pop`:
 ```c
-auto read = queue_events.PopOptional();
+auto read = queue_events.Pop();
 
 if (read) {
     actor2.ProcessEvent(read);

docs/spsc/queue.md

@@ -30,7 +30,7 @@ if (read_success) {
 
 There is also a `std::optional` API for the `Pop` method:
 ```c
-auto read = queue_adc.PopOptional();
+auto read = queue_adc.Pop();
 
 if (read) {
     DoStuffWithData(read);

lockfree/mpmc/priority_queue.hpp

@@ -83,7 +83,7 @@ template <typename T, size_t size, size_t priority_count> class PriorityQueue {
      * Should only be called from the consumer thread.
      * @retval Either the element or nothing if the queue is empty.
      */
-    std::optional<T> PopOptional();
+    std::optional<T> Pop();
 #endif
 
     /********************** PRIVATE MEMBERS ***********************/

lockfree/mpmc/priority_queue_impl.hpp

@@ -68,7 +68,7 @@ bool PriorityQueue<T, size, priority_count>::Pop(T &element) {
 /********************* std::optional API **********************/
 #if __cplusplus >= 201703L || (defined(_MSVC_LANG) && _MSVC_LANG >= 201703L)
 template <typename T, size_t size, size_t priority_count>
-std::optional<T> PriorityQueue<T, size, priority_count>::PopOptional() {
+std::optional<T> PriorityQueue<T, size, priority_count>::Pop() {
     T element;
     bool result = Pop(element);
 

lockfree/mpmc/queue.hpp

@@ -80,7 +80,7 @@ template <typename T, size_t size> class Queue {
      * @brief Removes an element from the queue.
      * @retval Either the element or nothing
      */
-    std::optional<T> PopOptional();
+    std::optional<T> Pop();
 #endif
 
     /*********************** PRIVATE TYPES ************************/

lockfree/mpmc/queue_impl.hpp

@@ -113,8 +113,7 @@ template <typename T, size_t size> bool Queue<T, size>::Pop(T &element) {
 
 /********************* std::optional API **********************/
 #if __cplusplus >= 201703L || (defined(_MSVC_LANG) && _MSVC_LANG >= 201703L)
-template <typename T, size_t size>
-std::optional<T> Queue<T, size>::PopOptional() {
+template <typename T, size_t size> std::optional<T> Queue<T, size>::Pop() {
     T element;
     bool result = Pop(element);
 

lockfree/spsc/priority_queue.hpp

@@ -84,7 +84,7 @@ template <typename T, size_t size, size_t priority_count> class PriorityQueue {
      * Should only be called from the consumer thread.
      * @retval Either the element or nothing if the queue is empty.
      */
-    std::optional<T> PopOptional();
+    std::optional<T> Pop();
 #endif
 
     /********************** PRIVATE MEMBERS ***********************/

lockfree/spsc/priority_queue_impl.hpp

@@ -69,7 +69,7 @@ bool PriorityQueue<T, size, priority_count>::Pop(T &element) {
 /********************* std::optional API **********************/
 #if __cplusplus >= 201703L || (defined(_MSVC_LANG) && _MSVC_LANG >= 201703L)
 template <typename T, size_t size, size_t priority_count>
-std::optional<T> PriorityQueue<T, size, priority_count>::PopOptional() {
+std::optional<T> PriorityQueue<T, size, priority_count>::Pop() {
     T element;
     bool result = Pop(element);
 

lockfree/spsc/queue.hpp

@@ -83,7 +83,7 @@ template <typename T, size_t size> class Queue {
      * Should only be called from the consumer thread.
      * @retval Either the element or nothing
      */
-    std::optional<T> PopOptional();
+    std::optional<T> Pop();
 #endif
 
     /********************** PRIVATE MEMBERS ***********************/

lockfree/spsc/queue_impl.hpp

@@ -94,8 +94,7 @@ template <typename T, size_t size> bool Queue<T, size>::Pop(T &element) {
 
 /********************* std::optional API **********************/
 #if __cplusplus >= 201703L || (defined(_MSVC_LANG) && _MSVC_LANG >= 201703L)
-template <typename T, size_t size>
-std::optional<T> Queue<T, size>::PopOptional() {
+template <typename T, size_t size> std::optional<T> Queue<T, size>::Pop() {
     T element;
     bool result = Pop(element);
 

tests/mpmc/priority_queue.cpp

@@ -74,6 +74,6 @@ TEST_CASE("mpmc::PriorityQueue - Optional API", "[mpmc_pq_optional_api]") {
     bool const push_success = queue.Push(-1024, 0);
     REQUIRE(push_success);
 
-    auto const read = queue.PopOptional();
+    auto const read = queue.Pop();
     REQUIRE(read == -1024);
 }

tests/mpmc/queue.cpp

@@ -84,8 +84,8 @@ TEST_CASE("mpmc::Queue - Write with overflow and read back from start",
 TEST_CASE("mpmc::Queue - Optional API", "[mpmc_q_optional_api]") {
     lockfree::mpmc::Queue<uint64_t, 32> queue;
 
-    REQUIRE(!queue.PopOptional());
+    REQUIRE(!queue.Pop());
     queue.Push(-1024);
 
-    REQUIRE(queue.PopOptional() == -1024);
+    REQUIRE(queue.Pop() == -1024);
 }

tests/spsc/priority_queue.cpp

@@ -148,6 +148,6 @@ TEST_CASE("spsc::PriorityQueue - Optional API", "[pq_optional_api]") {
     bool const push_success = queue.Push(-1024, 0);
     REQUIRE(push_success);
 
-    auto const read = queue.PopOptional();
+    auto const read = queue.Pop();
     REQUIRE(read == -1024);
 }

tests/spsc/queue.cpp

@@ -84,10 +84,10 @@ TEST_CASE("spsc::Queue - Write with overflow and read back from start",
 TEST_CASE("spsc::Queue - Optional API", "[q_optional_api]") {
     lockfree::spsc::Queue<uint64_t, 20> queue;
 
-    REQUIRE(!queue.PopOptional());
+    REQUIRE(!queue.Pop());
     queue.Push(-1024);
 
-    REQUIRE(queue.PopOptional() == -1024);
+    REQUIRE(queue.Pop() == -1024);
 }
 
 TEST_CASE("spsc::Queue - Multithreaded read/write", "[q_multithread]") {