Merged
Conversation
This needs further investigation about the theory, that the empty blocks are the result of a Nodes proposing transactions that were already imported in the last block, but the `best_transactions` data has not been updated yet. Also investigate if Nonce Gaps in normal transactions or service transactions are leading to proposals. is `best_transactions` already a collection that is filtered for nonce gaps ?!
…ges have been downgradet to debug.
…re is no block production.
…ne, we do not need to call update_honeybadger here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request primarily improves code clarity and maintainability in the consensus and mining components by adding explanatory comments, refining log messages, and removing unused or obsolete code paths. The changes help document tricky edge cases, clarify logging output, and streamline the engine's update process.
Comments and Documentation Improvements:
TransactionQueue::pendingandHoneyBadgerBFT::propose_blockto explain potential race conditions where the transaction pool cache may be stale after block import, and to clarify the implications of transaction pool maintenance timing. [1] [2]Logging Enhancements:
HbbftEarlyEpochEndManagerto more clearly state why early epoch end reports are skipped, now referencing elapsed time since the last block rather than ambiguous timestamps.info!todebug!inEthSyncfor errors encountered while sending consensus messages, reducing unnecessary log noise and clarifying the node context.Code Cleanup and Refactoring:
HoneyBadgerBFT::set_signerthat previously attempted to update the HoneyBadger state and log issues if the client was not yet set, simplifying the signer update logic.