Skip to content

CPACS XSD: Move wrong node type restriction into element attribute#1325

Draft
svengoldberg wants to merge 1 commit into
mainfrom
1324-fix_wrong_CPACS_type_restriction
Draft

CPACS XSD: Move wrong node type restriction into element attribute#1325
svengoldberg wants to merge 1 commit into
mainfrom
1324-fix_wrong_CPACS_type_restriction

Conversation

@svengoldberg

@svengoldberg svengoldberg commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

TODO: Choose new CPACS XSD as basis...

Wait for DLR-SL/CPACS#864 to be merged!

The new CPACS node for the approximationSettings brings a node structure that introduces a wrong type restriction.
This did not stand out within the code generator or TiGL but within the mentioned CPACS PR.

To avoid several PR for potential more changes within the CPACS repo, do not merge this PR before the other one is done.

Fix #1324.

Description

How Has This Been Tested?

Screenshots, that help to understand the changes(if applicable):

Checklist:

Task Finished Reviewer Approved
At least one test for the new functionality was added.
  • yes
  • does not apply
  • OK
New classes have been added to the Python interface.
  • yes
  • does not apply
  • OK
The code is properly documented with doxygen docstrings
  • yes
  • does not apply
  • OK
Changes are documented at the top of ChangeLog.md
  • yes
  • does not apply
  • OK

@codecov

codecov Bot commented Jun 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.58%. Comparing base (09375d1) to head (103e5ee).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1325   +/-   ##
=======================================
  Coverage   72.58%   72.58%           
=======================================
  Files         316      316           
  Lines       27750    27750           
=======================================
  Hits        20141    20141           
  Misses       7609     7609           
Flag Coverage Δ
unittests 72.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update CPACS XSD to remove wrong type restriction

1 participant