Return empty shapes instead of throwing exceptions if nacelle or pylon definition is missing#1323
Open
joergbrech wants to merge 4 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1323 +/- ##
==========================================
+ Coverage 72.96% 73.03% +0.06%
==========================================
Files 322 322
Lines 28290 28297 +7
==========================================
+ Hits 20643 20667 +24
+ Misses 7647 7630 -17
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
…but-without-nacelle
svengoldberg
requested changes
Jun 12, 2026
svengoldberg
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me!
I just have a small question...
After that, for me, the PR is ready to merge
| boost::optional<CCPACSEngineNacelle>& nacelle = engine.GetNacelle(); | ||
| auto transform = this->GetTransformationMatrix(); | ||
| CTiglEngineNacelleBuilder builder(*nacelle, transform); | ||
| return builder.BuildShape(); |
Contributor
There was a problem hiding this comment.
Just to be safe, I am not too familiar with the lofting of nacelles...
Is it impossible that this code part might throw an error, because of the if-check before?
In the old code, there is this try/catch block
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #779.
TiGL previously threw a CTiglError when trying to display an aircraft configuration containing an engine without a nacelle definition (e.g., an engine buried in the fuselage) or a pylon without geometry segments. This prevented the aircraft from being displayed at all in TiGLCreator.
Changes
How Has This Been Tested?
Screenshots, that help to understand the changes(if applicable):
Checklist: