Scene graph draw options by ole-alb · Pull Request #1279 · DLR-SC/tigl

ole-alb · 2026-01-05T12:13:13Z

In this PR the draw options are introduced to the display options.
This makes it easy for the user to display the flaps or e.g. the triangulation.

Description

How Has This Been Tested?

Screenshots, that help to understand the changes(if applicable):

Checklist:

Task	Finished	Reviewer Approved
At least one test for the new functionality was added.	yes does not apply	OK
New classes have been added to the Python interface.	yes does not apply	OK
The code is properly documented with doxygen docstrings	yes does not apply	OK
Changes are documented at the top of ChangeLog.md	yes does not apply	OK

…h-draw-options

…raw-options

…h-draw-options

codecov · 2026-01-05T12:21:35Z

Codecov Report

❌ Patch coverage is 76.19048% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.55%. Comparing base (8eb0b43) to head (62a43a0).

Files with missing lines	Patch %	Lines
src/wing/CCPACSWing.cpp	76.19%	5 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1279   +/-   ##
=======================================
  Coverage   72.55%   72.55%           
=======================================
  Files         315      315           
  Lines       27540    27561   +21     
=======================================
+ Hits        19982    19998   +16     
- Misses       7558     7563    +5

Flag	Coverage Δ
unittests	`72.55% <76.19%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
src/wing/CCPACSWing.h	`100.00% <ø> (ø)`
src/wing/CCPACSWing.cpp	`84.93% <76.19%> (-0.21%)`	⬇️

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…them in two places

joergbrech

Thanks! This looks great! I noticed a few things.

When selecting "Show the complete aircraft with duct cutouts, the aircraft is generated a few times in a succession. This happens also with draw options that open a dialog: The dialog opens several times.
The Draw Options entry exists also for geometries, that have no options, such as engines or engine pylons. The drop down menu is empty.
There are some draw options that I would remove from the drop down, e.g. "Draw Control Point Net", "Show intersection line" and "Draw any component". I feel like these are not a property of the aircraft geometry but a separate function that should be kept in a menu.
Some draw options could be disabled/excluded from the drop down, if they are not defined (far field, systems, ducts, flaps, structure)
The draw options are all called "Show ...". IMHO we can remove the "Show".
When selecting "Show Fuselage Profile" and then choosing another draw option for the fuselage, the profile is not removed.
When selecting "Show Wing Profiles" and then choosing another draw option nothing happens. I am stuck on the profile view.
When selecting "Show Wing Component segment points" a dialog for the eta xsi coordinaes appear several times. Maybe we can remove this draw option and just keep it in the menu?
Please add a changelog entry.

joergbrech · 2026-06-08T10:45:09Z

+    /**
+     * @brief Returns the mirrored loft at the wings symmetry plane
+     * @param input_shape Shape to be mirrored with the wings symmetry
+     * @return PNamedShape
+     */


Eventhough we talked about this, now that some time has past I find this function a bit confusing. Why does it take an argument? What happens if the argument is nullptr? I think this function could use more explaining documentation.

joergbrech · 2026-06-08T10:46:47Z

+    std::string mirrorName = mirroredShape->Name();
+    mirrorName += "M";
+    std::string mirrorShortName = mirroredShape->ShortName();
+    mirrorShortName += "M";
+    mirroredShape->SetName(mirrorName.c_str());
+    mirroredShape->SetShortName(mirrorShortName.c_str());


I think we agreed on a different suffix for mirrored uids? :mirrored

joergbrech · 2026-06-08T10:48:30Z

+
+    // for (const auto& action : getDrawOptionsActions()) {
+    //     QAction* act = findChild<QAction*>(action.name);
+    //     if (act) {
+    //         connect(act, &QAction::triggered, this, [this, action]() {
+    //             action.handler(currentUid); // Pass the UID
+    //         });
+    //     }
+    // }


dev artifact?

Suggested change

// for (const auto& action : getDrawOptionsActions()) {

// QAction* act = findChild<QAction*>(action.name);

// if (act) {

// connect(act, &QAction::triggered, this, [this, action]() {

// action.handler(currentUid); // Pass the UID

// });

// }

// }

joergbrech · 2026-06-08T13:37:54Z

+    void drawWingComponentSegmentPoints(const QString& wingUID=nullptr);
+    void drawWingShells(const QString& wingUID=nullptr);
+    void drawWingFlaps(const QString& wingUID=nullptr);
+    void drawWingStructure(const QString& wingUID=nullptr);


Why nullptr default argument? I am surprised we can convert a nullptr to a const QString& without compiler error in the first place.

Why do we need a default argument?

joergbrech · 2026-06-08T13:38:11Z

+    void drawFuselage(const QString& Uid=nullptr);
+    void drawFuselageTriangulation(const QString& Uid=nullptr);
+    void drawFuselageSamplePoints(const QString& Uid=nullptr);
+    void drawFuselageSamplePointsAngle(const QString& Uid=nullptr);
+    void drawFusedFuselage(const QString& Uid=nullptr);
+    void drawFuselageGuideCurves(const QString& Uid=nullptr);


See above. Why the nullptr default argument?

joergbrech · 2026-06-08T13:39:10Z


    // Rotor selection dialogs
-    QString dlgGetRotorSelection();
+    QString dlgGetRotorSelection(const QString& rotorUid=nullptr);


See above. Why the nullptr default argument?

joergbrech · 2026-06-08T13:39:19Z

+    QString dlgGetRotorBladeSelection(const QString& rotorBladeUid=nullptr);
+    QString dlgGetRotorBladeComponentSegmentSelection(const QString& rotorBladeCompSegUid=nullptr);


See above. Why the nullptr default argument?

joergbrech · 2026-06-08T13:39:31Z


    // Fuselage selection dialogs
-    QString dlgGetFuselageSelection();
+    QString dlgGetFuselageSelection(const QString& Uid=nullptr);


See above. Why the nullptr default argument?

joergbrech · 2026-06-08T13:51:20Z

+    for (int j = 1; j <= wing.GetComponentSegmentCount(); ++j) {
+        tigl::CCPACSWingComponentSegment& cs = wing.GetComponentSegment(j);
+
+        if (auto& teds = cs.GetControlSurfaces()->GetTrailingEdgeDevices()) {


Do we have to check if the cs has control surfaces in the first place?

joergbrech · 2026-06-08T13:51:42Z

+                }
+            }
+        }   
+        if (auto& leds = cs.GetControlSurfaces()->GetLeadingEdgeDevices()) {


See above. What if the cs has no control surfaces?

ole-alb added 9 commits December 15, 2025 14:12

add wing options

42dd3b1

Merge remote-tracking branch 'origin/display-options' into scene-grap…

686f413

…h-draw-options

Merge remote-tracking branch 'origin/display-options' into scene-grap…

72fd107

…h-draw-options

add draw functions

b716d35

Merge remote-tracking branch 'origin/display-options' into scene-grap…

8869e3c

…h-draw-options

Merge remote-tracking branch 'origin/display-options' into scene-grap…

da9d499

…h-draw-options

don't delete wing when displaying flaps

9407856

Merge remote-tracking branch 'origin/mirror-flaps' into scene-graph-d…

35cc524

…raw-options

Merge remote-tracking branch 'origin/display-options' into scene-grap…

c54c66e

…h-draw-options

ole-alb changed the base branch from main to display-options January 5, 2026 12:13

ole-alb added 19 commits January 8, 2026 12:22

fix mirrored flap transform

c51fbd1

apply flap transform for leds

eb2c509

fix display wing option

d9e7c9b

fix crash invalid uid

4481e66

fix reset button for wings

0d4fdcc

current state

3d89992

mirror ribs and spars

009cbe7

add wing structure to display options

4fb6591

add shells to display options

b173bb5

add component segments to display options

0032980

add fused wing

6619f61

rename show options

84f390e

use removeWingFlaps helper

c7b5cd8

use draw wing in drawfusedwing

942bb66

add sample points to display options

6169d98

add triangulation to display options

0408674

add overlay porfile points to display options

7f4b1cb

add wing guide curves to display options

0fb81ef

add fuselage options to display options

6013a5b

ole-alb and others added 4 commits February 4, 2026 13:43

add aircraft options

b22f2b0

add rotor to display functions

2fdd20b

create DrawOptionsActions to collect the actions in one file and use …

a4684f4

…them in two places

Merge branch 'display-options' into scene-graph-draw-options

8fdd3f3

ole-alb marked this pull request as ready for review February 6, 2026 15:16

ole-alb requested a review from joergbrech February 6, 2026 15:17

Merge branch 'display-options' into scene-graph-draw-options

a3d6033

ole-alb assigned joergbrech May 12, 2026

joergbrech mentioned this pull request May 22, 2026

TiGLCreator: Selection of a fuselage in the CPACS Tree is laggy #1275

Open

Base automatically changed from display-options to main May 22, 2026 11:46

ole-alb and others added 3 commits June 2, 2026 10:28

Merge remote-tracking branch 'origin' into scene-graph-draw-options

c1c3ca2

fix merge errors

f0c061e

Merge branch 'main' into scene-graph-draw-options

62a43a0

joergbrech requested changes Jun 8, 2026

View reviewed changes

joergbrech mentioned this pull request Jun 10, 2026

TiGLCreator: Persist draw options in TiGLCreatorSettings for potentially faster opening of CPACS files #1317

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Scene graph draw options#1279

Scene graph draw options#1279
ole-alb wants to merge 36 commits into
mainfrom
scene-graph-draw-options

ole-alb commented Jan 5, 2026 •

edited

Loading

Uh oh!

codecov Bot commented Jan 5, 2026 •

edited

Loading

Uh oh!

joergbrech left a comment

Uh oh!

joergbrech Jun 8, 2026

Uh oh!

joergbrech Jun 8, 2026

Uh oh!

joergbrech Jun 8, 2026

Uh oh!

joergbrech Jun 8, 2026

Uh oh!

joergbrech Jun 8, 2026

Uh oh!

joergbrech Jun 8, 2026

Uh oh!

joergbrech Jun 8, 2026

Uh oh!

joergbrech Jun 8, 2026

Uh oh!

joergbrech Jun 8, 2026

Uh oh!

joergbrech Jun 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		QString dlgGetRotorBladeSelection(const QString& rotorBladeUid=nullptr);
		QString dlgGetRotorBladeComponentSegmentSelection(const QString& rotorBladeCompSegUid=nullptr);

Conversation

ole-alb commented Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

How Has This Been Tested?

Screenshots, that help to understand the changes(if applicable):

Checklist:

Uh oh!

codecov Bot commented Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

joergbrech left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ole-alb commented Jan 5, 2026 •

edited

Loading

codecov Bot commented Jan 5, 2026 •

edited

Loading