Feature ghost interface restructuring overlap#2233
Draft
antjeHP wants to merge 10 commits intofeature-ghost_interface_restructuringfrom
Draft
Feature ghost interface restructuring overlap#2233antjeHP wants to merge 10 commits intofeature-ghost_interface_restructuringfrom
antjeHP wants to merge 10 commits intofeature-ghost_interface_restructuringfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2235
Description
Another ghost definition has been added, called overlapping ghost.
Neighborhood is defined here as follows: Elements of a grid have a positive stretch factor. Elements can be stretched by this factor, overlapping (at more than single points or edges) with other stretched elements. If this happens, the elements are considered neighboring.
For example. If all elements have a stretch factor of 1.0 or less, no element has a neighbor.
Another example: Given a uniform square grid all with a factor of 1.3, the neighbors by overlap correspond to the neighbors by common corners.
How works this definition:
The class of the overlapping ghost definition inherits from the base class for ghost definitions. The procedure of the do_ghost method is therefore similar.
A definitions object can be created either with or without a uniform stretch factor for all elements. However, a uniform factor can also be added or removed later.
Since the entire process of searching and exchanging the ghost element is encapsulated in the do_ghost method, the uniform factor cannot be changed instead.
The procedure of the do_ghost method:
All these boxes must be checked by the AUTHOR before requesting review:
Documentation:,Bugfix:,Feature:,Improvement:orOther:.All these boxes must be checked by the REVIEWERS before merging the pull request:
As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.
General
Tests
If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):
Scripts and Wiki
scripts/internal/find_all_source_files.shto check the indentation of these files.License
doc/(or already has one).